Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [Lens] Remove scss from annotations plugin, visualization-ui-components and gauge expression (#208891) #211567

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

…ts and gauge expression (elastic#208891)

## Summary

part of elastic#208908

Replaces scss to css-in-js. I've tested all the changes.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 91a19c0)
@kibanamachine kibanamachine merged commit 99fb278 into elastic:9.0 Feb 18, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
eventAnnotationListing 736 700 -36
expressionGauge 95 69 -26
lens 1806 1770 -36
observability 1340 1304 -36
total -134

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotationListing 233.7KB 218.6KB -15.1KB
expressionGauge 19.5KB 9.9KB -9.6KB
lens 1.6MB 1.6MB -11.9KB
total -36.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 13.7KB 13.7KB -1.0B

cc @mbondyra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants