-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move storage adapter and traced ES client into dedicated package #211578
Move storage adapter and traced ES client into dedicated package #211578
Conversation
/ci |
/ci |
/ci |
/ci |
/ci |
/ci |
…/kibana into flash1293/move-storage-adapter
/ci |
…/kibana into flash1293/move-storage-adapter
/ci |
/ci |
💔 Build Failed
Failed CI StepsHistory
|
/ci |
@@ -0,0 +1,4 @@ | |||
# Traced ES Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include a two line code example of how to create and use the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
#211761) # Backport This will backport the following commits from `main` to `8.x`: - Move storage adapter and traced ES client into dedicated package (#211578)](#211578) --------- Co-authored-by: kibanamachine <[email protected]>
The storage adapter helper is a very generic package. This PR moves it out of the observability server utils into a dedicated package to better reflect this and to be able to use it from non-observability contexts.
The same applies to the observability es client. This PR moves it as well and renames it to
TracedEsClient
in the same way.