Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage adapter and traced ES client into dedicated package #211578

Merged
merged 22 commits into from
Feb 19, 2025

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Feb 18, 2025

The storage adapter helper is a very generic package. This PR moves it out of the observability server utils into a dedicated package to better reflect this and to be able to use it from non-observability contexts.

The same applies to the observability es client. This PR moves it as well and renames it to TracedEsClient in the same way.

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 18, 2025
@flash1293
Copy link
Contributor Author

/ci

@flash1293 flash1293 changed the title Move storage adapter into dedicated package Move storage adapter and traced ES client into dedicated package Feb 18, 2025
@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@flash1293
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 18, 2025

💔 Build Failed

Failed CI Steps

History

@flash1293
Copy link
Contributor Author

/ci

@flash1293 flash1293 marked this pull request as ready for review February 19, 2025 08:25
@flash1293 flash1293 requested review from a team as code owners February 19, 2025 08:25
@@ -0,0 +1,4 @@
# Traced ES Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include a two line code example of how to create and use the client?

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293 flash1293 merged commit cb9c5f2 into elastic:main Feb 19, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13412242218

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- SKA: Fix kebab-case issues in security-threat-hunting packages (#211349)
- Deprecate universal entity
- [streams] lifecycle - ingestion and total docs metadata (#210301)
- Added versioning to inventory_view_saved_object (#207007)

Manual backport

To create the backport manually run:

node scripts/backport --pr 211578

Questions ?

Please refer to the Backport tool documentation

flash1293 added a commit that referenced this pull request Feb 19, 2025
#211761)

# Backport

This will backport the following commits from `main` to `8.x`:
- Move storage adapter and traced ES client into dedicated package
(#211578)](#211578)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants