bugfix #77: Fix error and debug line/columns #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #77 by:
lineCharIdx
to be fully 0-indexed: Currently, it's technically 0-indexed, but it gets set to 1 immediately when parsing starts becauseadvance()
gets called to loadchar
. On subsequent lines, it gets set to 0, but it gets reset when advancing to a newline character.lineIdx--
calls that I think were put in place to decrement the line counter after advancing to a newline when consuming some identifiers.The part I'm most unsure of is the if statement in the copy-paste section - I deleted that because it didn't seem to do anything useful with the changes above, but I don't fully understand why it was there in the first place, so if you could review that for me, I would be grateful.
Thank you!
The debug output of the example looks like this now: