Improved performance #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2016 17:18
- 'id' param will help improving the overall performance of application as the user will be able to fetch the required data directly by passing the 'id' i.e. previously used to store the data. - new TCs written for modified methods
Added `id` param to all Ariadne `get` methods
- 'id' param will help improving the overall performance of application as the user will be able to fetch the required data directly by passing the 'id' i.e. previously used to store the data. - new TCs written for modified methods added keyword arguments for 'get' methods added 'keyword arguments' & 'highredis' functionality
| def self.get_app_name(app_name: nil) | ||
| app_name ||= ENV['APP_NAME'] | ||
| app_name || '' | ||
| end |
There was a problem hiding this comment.
I think the above two lines can be written like this
app_name ||= ( ENV['APP_NAME'] || '' )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the user will be able to fetch the required data directly by passing the
'id' i.e. previously used to store the data.
added keyword arguments for 'get' methods
added 'keyword arguments' & 'highredis' functionality