-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Match account metadata icon names with trailing colons and add/update more icons #1693
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Specifically, I added/altered This also fixes it so a field called (Edits: I added more; I think this is all of them. I also rebased this so putting quotes around all icons is a separate commit so it is clear in the diff where I added icons.) |
b8e1696
to
0555517
Compare
92f8e7d
to
00f7829
Compare
@patak-dev I didn't realize that was something you wanted addressed in this PR since the duplicate key icons were already present. I can add an alias map later. |
@patak-dev Looking into this now, even after constructing an alias map, I am not sure how you want to decide which text label is the default for each icon. For instance, I am not sure how to decide whether the key icon should insert the “GPG”, “Keyoxide”, “PGP”, or “OpenPGP” label by default. |
@ZMYaro ah, I didn't realize that PGP and Language were both already duplicated. I think the issue with this PR is that it is a lot more evident after it. About what Label to use, we could select the most common one as the default (or any of them if all are similar in use). This is only to avoid duplicates in the picker, so I think it is ok to pick one of them. If the user writes the label by hand, the icon would still be properly assigned. |
@patak-dev I am thinking then having the alias list isn't the best solution for that menu, and it would be better to have a list of featured labels specifically for that component? Because I agree we (for example) don't need both “Home Page” and “Homepage”, but it does makes sense to keep both “GPG” and “Keyoxide” available. |
In the case of “GPG” and “Keyoxide”, they better have different icons if possible, no? Not an issue if some of them end up duplicated though for now. Just that we can't have |
@patak-dev Right now, they have the same icon (you can see right now in Elk stable). If we picked one label for each icon, we would have to pick one and rule out all the others. That was why I suggested it might work better to have a list of labels to suggest in the Edit: I pushed an implementation of that; let me know what you think. |
473cd7d
to
04516f2
Compare
04516f2
to
aa9951b
Compare
This also addresses the email half of #1683.