Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Underline footer links and move sponsor link down with them #1838

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ZMYaro
Copy link

@ZMYaro ZMYaro commented Mar 1, 2023

@stackblitz
Copy link

stackblitz bot commented Mar 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 8ea02dd
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/641394467443c9000813e210
😎 Deploy Preview https://deploy-preview-1838--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 8ea02dd
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64139446a35bbb000828a209

@ZMYaro ZMYaro changed the title Underline footer links and move sponsor link down with them feat(ui): Underline footer links and move sponsor link down with them Mar 1, 2023
@ZMYaro
Copy link
Author

ZMYaro commented Mar 1, 2023

image

@ZMYaro ZMYaro force-pushed the footer-link-restyle branch 2 times, most recently from 461f8a6 to e869e17 Compare March 16, 2023 08:45
@patak-dev
Copy link
Member

I think it is too much in a single line, and we lose the Privacy
image

I prefer we keep the sponsor heart button as it was before for now, or we could try two lines 🤔

Mastodon  Discord  Github
About  Privacy  ❤️ Sponsor

@ZMYaro
Copy link
Author

ZMYaro commented Mar 16, 2023

I think it is too much in a single line, and we lose the Privacy

I prefer we keep the sponsor heart button as it was before for now, or we could try two lines 🤔

@patak-dev I don't understand what you mean by “we lose the Privacy”. But thank you for catching I forgot to make it wrap when I changed it to a flexbox 🤦

Edit: Here is what it looks like:
image

@ZMYaro ZMYaro force-pushed the footer-link-restyle branch from 0927ece to 8ea02dd Compare March 16, 2023 22:12
@Shinigami92 Shinigami92 added c: feature Request for new feature c: ui Enhancing UI labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: ui Enhancing UI
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants