Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra padding and hover effect on dark theme #3157

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Jan 26, 2025

fix #3155

  • Remove the hover color similar to the light theme
  • Remove the extra padding. This was necessary not just for hovering, but the focus border also overflowed on the left side.

Before

screenshot of post with "more from" badge, hovering on the account name, its background is white and too much left padding
https://deploy-preview-3157--elk-zone.netlify.app/mastodon.social/@Mastodon/113820526480156595

After

screenshot of post with "more from" badge, hovering on the account name, no background color change with no extra padding
https://deploy-preview-3157--elk-zone.netlify.app/mastodon.social/@Mastodon/113820526480156595

Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 0f3f0b4
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6795eea0de2fbe000873cd82
😎 Deploy Preview https://deploy-preview-3157--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 0f3f0b4
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6795eea00759490008226cd0

@shuuji3
Copy link
Member Author

shuuji3 commented Jan 27, 2025

merging to include in the next release. This was a missing fix in the previous PR.

@shuuji3 shuuji3 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit f6a4716 Jan 27, 2025
18 checks passed
@shuuji3 shuuji3 deleted the shuuji3/fix/more-from-avatar-color-dark-theme branch January 27, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra padding when hovering account in "more from" badge
1 participant