Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: lazy load publish widget and other chunks #515

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 22, 2022

Currently we have a massive publish widget chunk that is loaded even for logged-out users. This PR lazy-loads certain components only after the site is interactive, which should improve TTI, particularly on a first visit to the site.

cc: @patak-dev as it touches some of the same code you're doing in #514

@danielroe danielroe self-assigned this Dec 22, 2022
@stackblitz
Copy link

stackblitz bot commented Dec 22, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 687033b
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63a476d9b511520008a20b94
😎 Deploy Preview https://deploy-preview-515--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

This is great! Eager to see what will be the final size once optimizations are in place. There are several things to lazy load on the timeline too later. The custom HTML cards for example may end up growing, and not always used.

@KaKi87 KaKi87 closed this Jan 4, 2023
@KaKi87 KaKi87 deleted the perf/lazy-publish branch January 4, 2023 17:49
@danielroe danielroe restored the perf/lazy-publish branch January 4, 2023 17:54
@danielroe danielroe reopened this Jan 4, 2023
@Shinigami92 Shinigami92 added the c: performance Related to performance label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: performance Related to performance
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants