Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build scripts #56

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

CMake build scripts #56

wants to merge 50 commits into from

Conversation

Frost-54
Copy link

Added CMake support and fixed some compile errors.
Compiles on latest version on Windows/Mac/Linux, but fail to compile on some older platforms(likely a compiler problem).

Summary:

  1. #undef linux on linux, because linux is defined by the compiler and used as an identifier.
  2. Added github CI.
  3. Cast return value of MAKEINTATOM to LPCWSTR because some functions expect a LPCWSTR not LPTSTR
  4. Make closeSocket a wrapper function on Windows because the compiler complains.
  5. Call to CreateMasteringVoice in IXAudio2CreateMasteringVoice is not valid.
  6. Most HRESULT error codes are larger than INT_MAX. Wrapped them in an 'enum ErrorCode'. Use ErrorCode in each ErrorCategory::message(). Also convert HRESULT to ErrorCode before passing to std::system_error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant