xdrgen: typedefs should use the built-in string and opaque functions

'typedef opaque yada<XYZ>' should use xdrgen's built-in opaque encoder and decoder, to enable better compiler optimization. Signed-off-by: Chuck Lever <[email protected]>
elodin-sys · Sep 20, 2024 · fed8a17 · fed8a17
1 parent 663ad8b
commit fed8a17
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tools/net/sunrpc/xdrgen/templates/C/typedef/decoder/variable_length_opaque.j2 b/tools/net/sunrpc/xdrgen/templates/C/typedef/decoder/variable_length_opaque.j2
@@ -13,5 +13,5 @@ xdrgen_decode_{{ name }}(struct xdr_stream *xdr, {{ classifier }}{{ name }} *ptr
 {% if annotate %}
 	/* (variable-length opaque) */
 {% endif %}
-	return xdr_stream_decode_opaque(xdr, ptr->data, ptr->len) >= 0;
+	return xdrgen_decode_opaque(xdr, ptr, {{ maxsize }});
 };
diff --git a/tools/net/sunrpc/xdrgen/templates/C/typedef/decoder/variable_length_string.j2 b/tools/net/sunrpc/xdrgen/templates/C/typedef/decoder/variable_length_string.j2
@@ -13,5 +13,5 @@ xdrgen_decode_{{ name }}(struct xdr_stream *xdr, {{ classifier }}{{ name }} *ptr
 {% if annotate %}
 	/* (variable-length string) */
 {% endif %}
-	return xdr_stream_decode_opaque(xdr, ptr->data, ptr->len) >= 0;
+	return xdrgen_decode_string(xdr, ptr, {{ maxsize }});
 };