Skip to content

Commit

Permalink
Change to klog
Browse files Browse the repository at this point in the history
  • Loading branch information
ldx committed Feb 6, 2020
1 parent 5cffabf commit c8b3ccc
Show file tree
Hide file tree
Showing 59 changed files with 570 additions and 570 deletions.
4 changes: 2 additions & 2 deletions cmd/virtual-kubelet/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"context"
"strings"

"github.com/elotl/cloud-instance-provider/pkg/glog"
"github.com/elotl/cloud-instance-provider/pkg/klog"
"github.com/elotl/cloud-instance-provider/pkg/server"
cli "github.com/virtual-kubelet/node-cli"
opencensuscli "github.com/virtual-kubelet/node-cli/opencensus"
Expand All @@ -39,7 +39,7 @@ var (
func main() {
ctx := cli.ContextWithCancelOnSignal(context.Background())

log.L = glog.NewGlogAdapter()
log.L = klog.NewKlogAdapter()

trace.T = opencensus.Adapter{}
traceConfig := opencensuscli.Config{
Expand Down
4 changes: 2 additions & 2 deletions pkg/api/codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package api
import (
"github.com/json-iterator/go"

"github.com/golang/glog"
"k8s.io/klog"
)

var json = jsoniter.ConfigCompatibleWithStandardLibrary
Expand Down Expand Up @@ -37,7 +37,7 @@ func (c JsonCodec) Marshal(i interface{}) ([]byte, error) {
func warnIfUnversioned(t TypeVersioner) {
version := t.GetAPIVersion()
if version == "" {
glog.Warningf("Found empty API version in registry for %v", t)
klog.Warningf("Found empty API version in registry for %v", t)
}
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/certs/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/docker/libkv/store"
"github.com/elotl/cloud-instance-provider/pkg/etcd"
"github.com/elotl/cloud-instance-provider/pkg/util"
"github.com/golang/glog"
"k8s.io/klog"
)

const (
Expand All @@ -33,7 +33,7 @@ func New(kvstore etcd.Storer) (*CertificateFactory, error) {
certFactory.kvstore.Put(CertificateDirectoryPlaceholder, []byte("."), nil)
err := certFactory.GetRootFromStore()
if err == store.ErrKeyNotFound {
glog.Infof("Initializing Milpa root certificate")
klog.Infof("Initializing Milpa root certificate")
certFactory.InitRootCert()
} else if err != nil {
return nil, util.WrapError(err, "Error creating Milpa PKI")
Expand Down
12 changes: 6 additions & 6 deletions pkg/etcd/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import (
"github.com/coreos/etcd/pkg/transport"
"github.com/docker/libkv/store"
"github.com/elotl/cloud-instance-provider/pkg/util"
"github.com/golang/glog"
"golang.org/x/sys/unix"
"k8s.io/klog"
)

var (
Expand All @@ -37,7 +37,7 @@ func ensureEtcdDataDir(dataDir string) error {
errMsg := fmt.Sprintf("Could not create milpa storage directory at %s, please verify the directory exists and is writable by milpa. The error was", dataDir)
_, err := os.Stat(dataDir)
if os.IsNotExist(err) {
glog.Infof("Creating milpa data directory at %s", dataDir)
klog.Infof("Creating milpa data directory at %s", dataDir)
err := os.MkdirAll(dataDir, 0750)
if err != nil {
return util.WrapError(err, errMsg)
Expand Down Expand Up @@ -86,13 +86,13 @@ func (s *EtcdServer) Start(quit <-chan struct{}, wg *sync.WaitGroup) error {
cfg.LCUrls = []url.URL{}
}
if cfg.AutoCompactionMode == "" {
glog.Info("Setting etcd compaction mode to periodic")
klog.Info("Setting etcd compaction mode to periodic")
cfg.AutoCompactionMode = compactor.ModePeriodic
}
if cfg.AutoCompactionMode == compactor.ModePeriodic &&
cfg.AutoCompactionRetention == "" {
cfg.AutoCompactionRetention = "1"
glog.Info("Setting etcd compaction interval to 1 hour")
klog.Info("Setting etcd compaction interval to 1 hour")
}

err = s.reconcileDataDirectoryValues(cfg)
Expand All @@ -110,7 +110,7 @@ func (s *EtcdServer) Start(quit <-chan struct{}, wg *sync.WaitGroup) error {
}
select {
case <-s.Proc.Server.ReadyNotify():
glog.Info("Etcd server is ready to serve requests")
klog.Info("Etcd server is ready to serve requests")
case <-time.After(60 * time.Second):
s.Proc.Server.Stop()
s.Proc.Close()
Expand All @@ -127,7 +127,7 @@ func (s *EtcdServer) Start(quit <-chan struct{}, wg *sync.WaitGroup) error {
<-quit
// if we don't pause, clients will crash, it's a bad look.
pause := 2 * time.Second
glog.Infof("Pausing for %ds before shutting down etcd...", int(pause.Seconds()))
klog.Infof("Pausing for %ds before shutting down etcd...", int(pause.Seconds()))
time.Sleep(pause)
s.Proc.Server.Stop()
s.Proc.Close()
Expand Down
4 changes: 2 additions & 2 deletions pkg/etcd/etcd_test_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"os"
"sync"

"github.com/golang/glog"
"k8s.io/klog"
)

func SetupEmbeddedEtcdTest() (*SimpleEtcd, func(), error) {
Expand All @@ -18,7 +18,7 @@ func SetupEmbeddedEtcdTest() (*SimpleEtcd, func(), error) {
closer := func() {
quit <- struct{}{}
if err := os.RemoveAll(dataDir); err != nil {
glog.Fatal("Error removing etcd data directory")
klog.Fatal("Error removing etcd data directory")
}
}
db := EtcdServer{
Expand Down
129 changes: 0 additions & 129 deletions pkg/glog/adapter.go

This file was deleted.

132 changes: 132 additions & 0 deletions pkg/klog/adapter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
package klog

import (
"flag"
"fmt"

"github.com/virtual-kubelet/virtual-kubelet/log"
"k8s.io/klog"
)

const (
errorKey = "error"
)

type KlogAdapter struct {
fields log.Fields
extraArgsStr string
extraFormatStr string
}

func NewKlogAdapter() *KlogAdapter {
klogFlags := flag.NewFlagSet("klog", flag.ExitOnError)
klog.InitFlags(klogFlags)
return &KlogAdapter{}
}

func (g *KlogAdapter) update() {
g.extraArgsStr = ""
for k, v := range g.fields {
g.extraArgsStr += fmt.Sprintf(" %s=%v", k, v)
}
g.extraFormatStr = ""
for k, v := range g.fields {
g.extraFormatStr += fmt.Sprintf(" %s=%v", k, v)
}
}

func (g *KlogAdapter) getArgs(args ...interface{}) []interface{} {
if len(g.extraArgsStr) > 0 {
return append(args, g.extraArgsStr)
}
return args
}

func (g *KlogAdapter) getFormat(format string) string {
return format + g.extraFormatStr
}

func (g *KlogAdapter) Debug(args ...interface{}) {
args = g.getArgs(args...)
if klog.V(4) {
klog.InfoDepth(1, args...)
}
}

func (g *KlogAdapter) Debugf(format string, args ...interface{}) {
format = g.getFormat(format)
if klog.V(4) {
klog.InfoDepth(1, fmt.Sprintf(format, args...))
}
}

func (g *KlogAdapter) Info(args ...interface{}) {
args = g.getArgs(args...)
klog.InfoDepth(1, args...)
}

func (g *KlogAdapter) Infof(format string, args ...interface{}) {
format = g.getFormat(format)
klog.InfoDepth(1, fmt.Sprintf(format, args...))
}

func (g *KlogAdapter) Warn(args ...interface{}) {
args = g.getArgs(args...)
klog.WarningDepth(1, args...)
}

func (g *KlogAdapter) Warnf(format string, args ...interface{}) {
format = g.getFormat(format)
klog.WarningDepth(1, fmt.Sprintf(format, args...))
}

func (g *KlogAdapter) Error(args ...interface{}) {
args = g.getArgs(args...)
klog.ErrorDepth(1, args...)
}

func (g *KlogAdapter) Errorf(format string, args ...interface{}) {
format = g.getFormat(format)
klog.ErrorDepth(1, fmt.Sprintf(format, args...))
}

func (g *KlogAdapter) Fatal(args ...interface{}) {
args = g.getArgs(args...)
klog.FatalDepth(1, args...)
}

func (g *KlogAdapter) Fatalf(format string, args ...interface{}) {
format = g.getFormat(format)
klog.FatalDepth(1, fmt.Sprintf(format, args...))
}

func (g *KlogAdapter) WithField(key string, value interface{}) log.Logger {
logger := &KlogAdapter{
fields: map[string]interface{}{
key: value,
},
}
logger.update()
return logger
}

func (g *KlogAdapter) WithFields(fields log.Fields) log.Logger {
logger := &KlogAdapter{
fields: make(map[string]interface{}),
}
for k, v := range fields {
logger.fields[k] = v
}
logger.update()
return logger
}

func (g *KlogAdapter) WithError(err error) log.Logger {
logger := &KlogAdapter{
fields: map[string]interface{}{
errorKey: err,
},
}
logger.update()
return logger
}
Loading

0 comments on commit c8b3ccc

Please sign in to comment.