Extract duplicated filter functions

emberobserver · Nov 16, 2019 · 82dbe65 · 82dbe65
1 parent 250ebf9
commit 82dbe65
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/app/components/dependency-tables.js b/app/components/dependency-tables.js
@@ -1,6 +1,9 @@
 import Component from '@ember/component';
 import { inject as service } from '@ember/service';
 
+const dependencies = (dep) => dep.isDependency;
+const devDependencies = (dep) => dep.isDevDependency;
+
 export default Component.extend({
   tagName: '',
 
@@ -15,8 +18,8 @@ export default Component.extend({
         sort: 'package',
       }).then((results) => {
         return {
-          dependencies: results.filter((dep) => dep.isDependency).map((dep) => dep.package),
-          devDependencies: results.filter((dep) => dep.isDevDependency).map((dep) => dep.package)
+          dependencies: results.filter(dependencies).map(dep => dep.package),
+          devDependencies: results.filter(devDependencies).map(dep => dep.package)
         };
       });
     },
@@ -27,8 +30,8 @@ export default Component.extend({
         include: 'dependent-version',
       }).then((results) => {
         return {
-          dependencies: results.filter(dep => dep.isDependency).map(dep => dep.dependentVersion.get('addonName')).sort(),
-          devDependencies: results.filter(dep => dep.isDevDependency).map(dep => dep.dependentVersion.get('addonName')).sort()
+          dependencies: results.filter(dependencies).map(dep => dep.dependentVersion.get('addonName')).sort(),
+          devDependencies: results.filter(devDependencies).map(dep => dep.dependentVersion.get('addonName')).sort()
         };
       });
     }