Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in TextEdit::singleline layout #5640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IaVashik
Copy link

This PR reverts a change introduced in PR #3660 that caused a regression with TextEdit::singleline. The original PR attempted to fix an issue with the cursor in TextEdit inside ScrollArea, but it did so by adding unnecessary size allocation to TextEdit, which breaks the layout when TextEdit::singleline is used outside of ScrollArea.

Image

The regression introduced by #3660 is more severe, as it completely breaks the layout of applications using TextEdit::singleline, as shown in the following issues:

Furthermore, I was unable to reproduce the original bug from PR #3660 in the current version of egui using the following code:

impl eframe::App for MyEguiApp {
    fn update(&mut self, ctx: &egui::Context, _: &mut eframe::Frame) {
        ctx.set_debug_on_hover(true);
        egui::CentralPanel::default().show(ctx, |ui| {
            ScrollArea::vertical().max_height(100.0).show(ui, |ui| {
                ui.add(TextEdit::multiline(&mut self.text).hint_text("Enter text here..."))
            });
        });
    }
}

This code attempts to recreate the layout shown in the video from PR #3660, using a ScrollArea with limited height and a TextEdit inside. However, the cursor hiding issue was not reproducible.
Video_2025-01-26_17-54-24

Therefore, I believe the code added in PR #3660 is no longer necessary and only creates more problems.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk mentioned this pull request Jan 21, 2025
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5640-master
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk
Copy link
Owner

emilk commented Jan 27, 2025

There are some clippy failures that need fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants