Page number in trade history params should be zero-based (so default …

…should be 0)
emircem · Oct 19, 2016 · 4e87245 · 4e87245
1 parent d1a99f8
commit 4e87245
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...inbase/src/main/java/org/knowm/xchange/coinbase/service/polling/CoinbaseTradeService.java b/...inbase/src/main/java/org/knowm/xchange/coinbase/service/polling/CoinbaseTradeService.java
@@ -91,7 +91,7 @@ public Collection<Order> getOrder(String... orderIds)
  public TradeHistoryParams createTradeHistoryParams() {
 
  DefaultTradeHistoryParamPaging params = new DefaultTradeHistoryParamPaging();
- params.setPageNumber(1);
+ params.setPageNumber(0);
  params.setPageLength(100);
  return params;
  }

diff --git a/...n/java/org/knowm/xchange/service/polling/trade/params/DefaultTradeHistoryParamPaging.java b/...n/java/org/knowm/xchange/service/polling/trade/params/DefaultTradeHistoryParamPaging.java
@@ -6,6 +6,7 @@
 public class DefaultTradeHistoryParamPaging implements TradeHistoryParamPaging {
 
  private Integer pageLength;
+ /** 0-based page number */
  private Integer pageNumber;
 
  public DefaultTradeHistoryParamPaging() {
@@ -15,6 +16,9 @@ public DefaultTradeHistoryParamPaging(Integer pageLength) {
  this(pageLength, 0);
  }
 
+ /**
+ * @param pageNumber 0-based page number
+ */
  public DefaultTradeHistoryParamPaging(Integer pageLength, Integer pageNumber) {
 
  this.pageLength = pageLength;
@@ -33,12 +37,14 @@ public void setPageLength(Integer pageLength) {
  this.pageLength = pageLength;
  }
 
+ /** 0-based page number */
  @Override
  public Integer getPageNumber() {
 
  return pageNumber;
  }
 
+ /** 0-based page number */
  @Override
  public void setPageNumber(Integer pageNumber) {