Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent hanging forever on non-DEFLATE zips #1467

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 5, 2025

Fixes: #1399

@emmercm emmercm self-assigned this Mar 5, 2025
@emmercm emmercm enabled auto-merge (squash) March 5, 2025 01:15
@emmercm emmercm merged commit 8cc42de into main Mar 5, 2025
54 checks passed
@emmercm emmercm deleted the emmercm/detect-non-deflate branch March 5, 2025 01:30
Copy link

github-actions bot commented Mar 5, 2025

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (8ab6289) to head (1b96aee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/types/files/archives/zip.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   92.61%   92.55%   -0.06%     
==========================================
  Files         122      122              
  Lines        7635     7645      +10     
  Branches     1747     1739       -8     
==========================================
+ Hits         7071     7076       +5     
- Misses        539      544       +5     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IGIR just stops
1 participant