Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: treat SNES enhancement chips as non-retail #1480

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 11, 2025

Fixes: #1342

@emmercm emmercm self-assigned this Mar 11, 2025
@emmercm emmercm enabled auto-merge (squash) March 11, 2025 01:01
@emmercm emmercm merged commit 26927b6 into main Mar 11, 2025
55 checks passed
@emmercm emmercm deleted the emmercm/snes-enhancement-chip branch March 11, 2025 01:07
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (4218679) to head (9511a91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         122      122           
  Lines        7634     7637    +3     
  Branches     1752     1751    -1     
=======================================
+ Hits         7057     7060    +3     
  Misses        552      552           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Chip roms are still imported even with the --only-retail flag.
1 participant