Fixed #26620 -- Made Model.refresh_from_db() fail when passed unknown…

… kwargs.
emulbreh · May 18, 2016 · b9ae662 · b9ae662
1 parent a5c8072
commit b9ae662
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/django/db/models/base.py b/django/db/models/base.py
@@ -646,7 +646,7 @@ def get_deferred_fields(self):
             if f.attname not in self.__dict__
         }
 
-    def refresh_from_db(self, using=None, fields=None, **kwargs):
+    def refresh_from_db(self, using=None, fields=None):
         """
         Reloads field values from the database.
 

diff --git a/docs/ref/models/instances.txt b/docs/ref/models/instances.txt
@@ -128,7 +128,7 @@ in the ``from_db()`` method.
 Refreshing objects from database
 ================================
 
-.. method:: Model.refresh_from_db(using=None, fields=None, **kwargs)
+.. method:: Model.refresh_from_db(using=None, fields=None)
 
 If you need to reload a model's values from the database, you can use the
 ``refresh_from_db()`` method. When this method is called without arguments the

diff --git a/tests/basic/tests.py b/tests/basic/tests.py
@@ -690,6 +690,11 @@ def test_refresh(self):
             a.refresh_from_db()
             self.assertEqual(a.pub_date, new_pub_date)
 
+    def test_unknown_kwarg(self):
+        s = SelfRef.objects.create()
+        with self.assertRaises(TypeError):
+            s.refresh_from_db(unknown_kwarg=10)
+
     def test_refresh_fk(self):
         s1 = SelfRef.objects.create()
         s2 = SelfRef.objects.create()