Updated memcache error checking to handle large object exception (Goo…

…gleCloudPlatform#748)
engeshra · Jan 6, 2017 · 538078d · 538078d
1 parent fcdb9ea
commit 538078d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/appengine/standard/memcache/guestbook/app.yaml b/appengine/standard/memcache/guestbook/app.yaml
@@ -3,7 +3,6 @@
 # https://developers.google.com/appengine/docs/python/config/appconfig
 # for details.
 
-version: 1
 runtime: python27
 api_version: 1
 threadsafe: yes

diff --git a/appengine/standard/memcache/guestbook/main.py b/appengine/standard/memcache/guestbook/main.py
@@ -85,9 +85,13 @@ def get_greetings(self, guestbook_name):
         greetings = memcache.get('{}:greetings'.format(guestbook_name))
         if greetings is None:
             greetings = self.render_greetings(guestbook_name)
-            if not memcache.add('{}:greetings'.format(guestbook_name),
-                                greetings, 10):
-                logging.error('Memcache set failed.')
+            try:
+                added = memcache.add(
+                    '{}:greetings'.format(guestbook_name), greetings, 10)
+                if not added:
+                    logging.error('Memcache set failed.')
+            except ValueError:
+                logging.error('Memcache set failed - data larger than 1MB')
         return greetings
     # [END check_memcache]