Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Storage #12119

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Refactoring Storage #12119

wants to merge 28 commits into from
+1,637 −2,027

Conversation

jdunkerley
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@jdunkerley
Update Interface.
0c34336
@jdunkerley
Update base Storage and SpecializedStorage.
e6d714c
@jdunkerley
Update BigDecimalStorage.
c95a526
@jdunkerley
Update BigIntegerStorage.
e635538 
Replace getItemAsObject with getBoxed.
@jdunkerley
Fix as ColumnStorage is now generic.
4991572
@jdunkerley
Update the datetime storages.
50328f3
@jdunkerley
Update StringStorage.
8add472
@jdunkerley
Update ObjectStorage and MixedStorage.
e3e69f6
@jdunkerley
Removing StringStorage constructors in favour of builders.
8bf5b45
@jdunkerley
Work on Long and Double storage.
56989a0 
Still in progress.
@jdunkerley
Remove a fair amount of new LongStorage.
49f36ae 
Left `AddGroupNumber`, `AddRowNumber` and `AddRunning`.
@jdunkerley
Java formatting.
1f18276
@jdunkerley
Java formatting.
6158438
@jdunkerley
More WIP.
e0c6d6c
@jdunkerley
Rename get to getPrimitive so can find easily.
156fd34 
Remove last usage of `getItem`.
Fix so can build.
@jdunkerley
Working through size.
2aa0865
@jdunkerley
Working through size (2).
8e3a2fc
@jdunkerley
Working through size (3).
dbe4b3a
@jdunkerley
Fix build issue.
1572a4e
@jdunkerley
Some tests fixed.
a0c90cc 
Working on size still.
@jdunkerley
Use long indexes.
598efaa
@jdunkerley
Most of size gone and most of constructor use replaces.
b265313
@jdunkerley
Basically complete.
8ad8adc 
Still to rename back getBoxed and getPrimitive.
Failing 10 tests.
Rebase next.
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 25, 2025
@jdunkerley jdunkerley marked this pull request as ready for review January 26, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdunkerley