Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine single-value column to treat it as that single value #12120

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

Refine single-value column to treat it as that single value #12120

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ac478e5
refine single value column type
radeusgd Jan 22, 2025
85fa20e
checkpoint
radeusgd Jan 22, 2025
5a24c2c
debugging
radeusgd Jan 22, 2025
7d10624
NPE in dispatch
radeusgd Jan 22, 2025
5b5f09c
assert
radeusgd Jan 22, 2025
22a39a5
Use TypeOfNode which understands java.time.LocalDate & co.
JaroslavTulach Jan 22, 2025
6ba616b
Merge branch 'develop' into wip/radeusgd/12095-column-as-single-value
radeusgd Jan 23, 2025
04c63e6
base sig
radeusgd Jan 23, 2025
38921c2
re-enabling tests
radeusgd Jan 23, 2025
e81546e
revert sig
radeusgd Jan 23, 2025
586de76
add a few more tests
radeusgd Jan 23, 2025
06dca42
re-add return check after discussion
radeusgd Jan 23, 2025
cc8d523
adapt tests to assumption that we require explicit cast to extract th…
radeusgd Jan 23, 2025
d0044e4
debug
radeusgd Jan 23, 2025
9bb73ae
Avoid dispatch of Any methods on EnsoMultiValue - see also #11827 and…
JaroslavTulach Jan 24, 2025
528bb50
Merge branch 'develop' into wip/radeusgd/12095-column-as-single-value
radeusgd Jan 24, 2025
20c6e81
fix wrongly written test
radeusgd Jan 24, 2025
ef26c37
split tests
radeusgd Jan 24, 2025
3ca42e7
CR: move conversions, update comments
radeusgd Jan 24, 2025
167aeb1
CR: remove redundant unchecked sig
radeusgd Jan 24, 2025
1700cd0
CR: Float is not an Int even if it has 0 fractional part
radeusgd Jan 24, 2025
d98b042
add first sig (rest will be in #12138)
radeusgd Jan 24, 2025
4820070
CR: add rhs test (but still needs cast)
radeusgd Jan 24, 2025
f757300
Workaround for an apparent pattern matching bug?
radeusgd Jan 24, 2025
3fc9d1f
Merge branch 'develop' into wip/radeusgd/12095-column-as-single-value
radeusgd Jan 24, 2025
41db180
yet another fix
radeusgd Jan 24, 2025
464f064
port fix from #12139 to be able to read logs
radeusgd Jan 24, 2025
29f1451
another workaround for matching bug
radeusgd Jan 24, 2025
26ce1c1
need to use the type from the match as it may have extracted something
radeusgd Jan 24, 2025
fc57147
fix ordering of cases
radeusgd Jan 24, 2025
7c937d7
Merge branch 'develop' into wip/radeusgd/12095-column-as-single-value
radeusgd Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
yet another fix
  • Loading branch information
@radeusgd
radeusgd committed Jan 24, 2025
commit 41db18072d5a12d39d0e8f74fad2561b7fb5157a
4 changes: 2 additions & 2 deletions distribution/lib/Standard/Table/0.0.0-dev/src/Column.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,8 +1204,8 @@ type Column
storage_type = Storage.from_value_type_strict common_type
new_storage = Java_Problems.with_problem_aggregator Problem_Behavior.Report_Warning java_problem_aggregator->
case default of
Column.Value java_col ->
other_storage = java_col.getStorage
col : Column ->
other_storage = col.java_column.getStorage
storage.fillMissingFrom other_storage storage_type java_problem_aggregator
_ ->
storage.fillMissing default storage_type java_problem_aggregator
Expand Down