Fix http4k#397 Fix up dependencies to not pull in optionals to maven …

…publications (http4k#398)

* replaced provided dependencies with compileOnly, so things appear correctly in maven POMs

CHANGELOG.md

@@ -5,6 +5,7 @@ changes with their rationale when appropriate:
 
 ### v3.244.0 (uncut)
 - [all] Upgrade some dependency versions.
+- [all] [Breaking (if you're not using it right!)] Fix #397 - Fixed up Maven dependencies so that they are not bringing in runtime libraries.
 - [http4k-core] - Add enum StringBiDiMapping #395 - H/T @goodhoko
 
 ### v3.243.0

build.gradle

@@ -10,7 +10,6 @@ buildscript {
         classpath Libs.coveralls_gradle_plugin
         classpath Libs.dokka_gradle_plugin
         classpath Libs.com_jfrog_bintray_gradle_plugin
-        classpath Libs.nebula_provided_base_gradle_plugin
         classpath Libs.openapi_generator_gradle_plugin
         classpath Libs.kotlin_serialization
     }
@@ -20,7 +19,6 @@ plugins {
     id 'com.github.kt3k.coveralls' version "2.9.0"
     id "com.jfrog.bintray" version "1.8.4"
     id 'de.fayard.buildSrcVersions' version "0.7.0"
-    id 'nebula.provided-base' version "3.0.3"
     id 'net.saliman.cobertura' version "3.0.0"
 }
 
@@ -38,7 +36,6 @@ allprojects {
     apply plugin: 'com.jfrog.bintray'
     apply plugin: 'maven'
     apply plugin: 'maven-publish'
-    apply plugin: 'nebula.provided-base'
     apply plugin: 'org.jetbrains.dokka'
 
     jacoco {
@@ -105,16 +102,16 @@ allprojects {
                         asNode().appendNode('description', description)
                         asNode().appendNode('url', 'https://http4k.org')
                         asNode().appendNode('developers')
-                                .appendNode('developer').appendNode('name', 'Ivan Sanchez').parent().appendNode('email', '[email protected]')
-                                .parent().parent()
-                                .appendNode('developer').appendNode('name', 'David Denton').parent().appendNode('email', '[email protected]')
+                            .appendNode('developer').appendNode('name', 'Ivan Sanchez').parent().appendNode('email', '[email protected]')
+                            .parent().parent()
+                            .appendNode('developer').appendNode('name', 'David Denton').parent().appendNode('email', '[email protected]')
                         asNode().appendNode('scm').
-                                appendNode('url', '[email protected]:http4k/' + archivesBaseName + '.git').parent().
-                                appendNode('connection', 'scm:git:[email protected]:http4k/' + archivesBaseName + '.git').parent().
-                                appendNode('developerConnection', 'scm:git:[email protected]:http4k/' + archivesBaseName + '.git')
+                            appendNode('url', '[email protected]:http4k/' + archivesBaseName + '.git').parent().
+                            appendNode('connection', 'scm:git:[email protected]:http4k/' + archivesBaseName + '.git').parent().
+                            appendNode('developerConnection', 'scm:git:[email protected]:http4k/' + archivesBaseName + '.git')
                         asNode().appendNode('licenses').appendNode('license').
-                                appendNode('name', 'Apache License, Version 2.0').parent().
-                                appendNode('url', 'http://www.apache.org/licenses/LICENSE-2.0.html')
+                            appendNode('name', 'Apache License, Version 2.0').parent().
+                            appendNode('url', 'http://www.apache.org/licenses/LICENSE-2.0.html')
                     }
                     from components.java
 
@@ -192,47 +189,45 @@ task jacocoRootReport(type: org.gradle.testing.jacoco.tasks.JacocoReport) {
 }
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-
-    provided project(":http4k-core")
-    provided project(":http4k-aws")
-    provided project(":http4k-client-apache")
-    provided project(":http4k-client-apache-async")
-    provided project(":http4k-client-jetty")
-    provided project(":http4k-client-okhttp")
-    provided project(":http4k-client-websocket")
-    provided project(":http4k-cloudnative")
-    provided project(":http4k-contract")
-    provided project(":http4k-format-argo")
-    provided project(":http4k-format-gson")
-    provided project(":http4k-format-jackson")
-    provided project(":http4k-format-jackson-xml")
-    provided project(":http4k-format-moshi")
-    provided project(":http4k-format-xml")
-    provided project(":http4k-incubator")
-    provided project(":http4k-jsonrpc")
-    provided project(":http4k-metrics-micrometer")
-    provided project(":http4k-multipart")
-    provided project(":http4k-resilience4j")
-    provided project(":http4k-security-oauth")
-    provided project(":http4k-server-apache")
-    provided project(":http4k-server-jetty")
-    provided project(":http4k-server-ktorcio")
-    provided project(":http4k-server-netty")
-    provided project(":http4k-server-undertow")
-    provided project(":http4k-serverless-lambda")
-    provided project(":http4k-template-dust")
-    provided project(":http4k-template-freemarker")
-    provided project(":http4k-template-handlebars")
-    provided project(":http4k-template-pebble")
-    provided project(":http4k-template-thymeleaf")
-    provided project(":http4k-template-dust")
-    provided project(":http4k-template-jade4j")
-    provided project(":http4k-testing-approval")
-    provided project(":http4k-testing-chaos")
-    provided project(":http4k-testing-hamkrest")
-    provided project(":http4k-testing-servirtium")
-    provided project(":http4k-testing-webdriver")
+    compile project(":http4k-core")
+    compile project(":http4k-aws")
+    compile project(":http4k-client-apache")
+    compile project(":http4k-client-apache-async")
+    compile project(":http4k-client-jetty")
+    compile project(":http4k-client-okhttp")
+    compile project(":http4k-client-websocket")
+    compile project(":http4k-cloudnative")
+    compile project(":http4k-contract")
+    compile project(":http4k-format-argo")
+    compile project(":http4k-format-gson")
+    compile project(":http4k-format-jackson")
+    compile project(":http4k-format-jackson-xml")
+    compile project(":http4k-format-moshi")
+    compile project(":http4k-format-xml")
+    compile project(":http4k-incubator")
+    compile project(":http4k-jsonrpc")
+    compile project(":http4k-metrics-micrometer")
+    compile project(":http4k-multipart")
+    compile project(":http4k-resilience4j")
+    compile project(":http4k-security-oauth")
+    compile project(":http4k-server-apache")
+    compile project(":http4k-server-jetty")
+    compile project(":http4k-server-ktorcio")
+    compile project(":http4k-server-netty")
+    compile project(":http4k-server-undertow")
+    compile project(":http4k-serverless-lambda")
+    compile project(":http4k-template-dust")
+    compile project(":http4k-template-freemarker")
+    compile project(":http4k-template-handlebars")
+    compile project(":http4k-template-pebble")
+    compile project(":http4k-template-thymeleaf")
+    compile project(":http4k-template-dust")
+    compile project(":http4k-template-jade4j")
+    compile project(":http4k-testing-approval")
+    compile project(":http4k-testing-chaos")
+    compile project(":http4k-testing-hamkrest")
+    compile project(":http4k-testing-servirtium")
+    compile project(":http4k-testing-webdriver")
 
     testCompile Config.TestDependencies
     testCompile project(path: ":http4k-testing-servirtium", configuration: 'testArtifacts')
@@ -256,7 +251,7 @@ dokka {
 
     subProjects = subprojects.collect { i -> i.name }
 
-    configuration  {
+    configuration {
         includes = ['src/packages.md']
         moduleName = "$rootProject.name"
         jdkVersion = 9

buildSrc/src/main/kotlin/Libs.kt

@@ -140,10 +140,6 @@ object Libs {
             "net.saliman.cobertura:net.saliman.cobertura.gradle.plugin:" +
             Versions.net_saliman_cobertura_gradle_plugin
 
-    const val nebula_provided_base_gradle_plugin: String =
-            "nebula.provided-base:nebula.provided-base.gradle.plugin:" +
-            Versions.nebula_provided_base_gradle_plugin
-
     const val com_jfrog_bintray_gradle_plugin: String =
             "com.jfrog.bintray:com.jfrog.bintray.gradle.plugin:" +
             Versions.com_jfrog_bintray_gradle_plugin

buildSrc/src/main/kotlin/Versions.kt

@@ -32,8 +32,6 @@ object Versions {
 
     const val net_saliman_cobertura_gradle_plugin: String = "3.0.0"
 
-    const val nebula_provided_base_gradle_plugin: String = "3.0.3" // available: "5.0.3"
-
     const val com_jfrog_bintray_gradle_plugin: String = "1.8.5"
 
     const val openapi_generator_gradle_plugin: String = "4.3.0"

http4k-aws/build.gradle

@@ -1,8 +1,7 @@
 description = 'Http4k AWS API client'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile project(":http4k-client-apache")

http4k-client-apache-async/build.gradle

@@ -1,12 +1,10 @@
 description = 'Http4k HTTP Client built on top of async apache httpclient'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.httpasyncclient
 
     testCompile project(path: ":http4k-core", configuration: "testArtifacts")
     testCompile Config.TestDependencies
 }
-

http4k-client-apache/build.gradle

@@ -1,12 +1,10 @@
 description = 'Http4k HTTP Client built on top of apache-httpclient'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.httpclient // apache
 
     testCompile project(path: ":http4k-core", configuration: "testArtifacts")
     testCompile Config.TestDependencies
 }
-

http4k-client-jetty/build.gradle

@@ -1,12 +1,10 @@
 description = 'HTTP Client built on top of jetty'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.jetty_client
 
     testCompile project(path: ":http4k-core", configuration: "testArtifacts")
     testCompile Config.TestDependencies
 }
-

http4k-client-okhttp/build.gradle

@@ -1,12 +1,10 @@
 description = 'HTTP Client built on top of okhttp'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.okhttp
 
     testCompile project(path: ":http4k-core", configuration: "testArtifacts")
     testCompile Config.TestDependencies
 }
-

http4k-client-websocket/build.gradle

@@ -1,13 +1,11 @@
 description = 'HTTP Websocket Client'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.java_websocket
 
     testCompile project(path: ":http4k-core", configuration: "testArtifacts")
     testCompile project(path: ":http4k-server-jetty")
     testCompile Config.TestDependencies
 }
-

http4k-cloudnative/build.gradle

@@ -1,8 +1,7 @@
 description = 'Machinery for running Http4k apps in cloud-native environments'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile project(":http4k-testing-hamkrest")

http4k-contract/build.gradle

@@ -3,10 +3,10 @@ description = 'http4k typesafe HTTP contracts and OpenApi support'
 apply plugin: 'org.openapi.generator'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
-    provided project(":http4k-format-jackson")
-    provided project(":http4k-security-oauth")
+    compile project(":http4k-core")
+    implementation project(":http4k-security-oauth")
+    implementation project(":http4k-format-jackson")
+
     compile Libs.kotlin_reflect
 
     testCompile project(":http4k-format-jackson")
@@ -38,4 +38,4 @@ task generateOpenApi2Client(type: org.openapitools.generator.gradle.plugin.tasks
 
 check.dependsOn("generateOpenApi3AutoClient")
 check.dependsOn("generateOpenApi3Client")
-check.dependsOn("generateOpenApi2Client")
+check.dependsOn("generateOpenApi2Client")

http4k-core/build.gradle

@@ -1,8 +1,8 @@
-description = 'sane HTTP request API for Kotlin'
+description = 'Dependency-lite Server as a Function in pure Kotlin'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided Libs.javax_servlet_api
+    compile Libs.kotlin_stdlib_jdk8
+    implementation Libs.javax_servlet_api
 
     testCompile Config.TestDependencies
     testCompile project(":http4k-client-apache")
@@ -11,4 +11,3 @@ dependencies {
     testCompile project(":http4k-testing-hamkrest")
     testCompile project(":http4k-server-jetty")
 }
-

http4k-format-argo/build.gradle

@@ -1,13 +1,11 @@
 description = 'Http4k Argo JSON support'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.argo
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile project(path: ":http4k-jsonrpc", configuration: 'testArtifacts')
     testCompile Config.TestDependencies
 }
-

http4k-format-gson/build.gradle

@@ -1,15 +1,11 @@
 description = 'Http4k GSON JSON support'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.gson
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile project(path: ":http4k-jsonrpc", configuration: 'testArtifacts')
     testCompile Config.TestDependencies
 }
-
-
-

http4k-format-jackson-xml/build.gradle

@@ -1,12 +1,11 @@
 description = 'Http4k XML support using Jackson as an underlying engine'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile project(":http4k-format-jackson")
     compile Libs.jackson_dataformat_xml
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile Config.TestDependencies
-}
+}

http4k-format-jackson/build.gradle

@@ -1,8 +1,7 @@
 description = 'Http4k Jackson JSON/XML support'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.jackson_databind
     compile Libs.jackson_module_kotlin
@@ -12,4 +11,4 @@ dependencies {
     testCompile project(path: ":http4k-jsonrpc", configuration: 'testArtifacts')
     testCompile project(":http4k-testing-approval")
     testCompile Config.TestDependencies
-}
+}

http4k-format-kotlinx-serialization/build.gradle

@@ -3,8 +3,7 @@ description = 'Http4k Kotlinx Serialization JSON support'
 apply plugin: 'kotlinx-serialization'
 
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.kotlinx_serialization_runtime
 

http4k-format-moshi/build.gradle

@@ -1,16 +1,11 @@
 description = 'Http4k Moshi JSON support'
 
-
 dependencies {
-    provided Libs.kotlin_stdlib_jdk8
-    provided project(":http4k-core")
+    compile project(":http4k-core")
 
     compile Libs.moshi
     compile Libs.moshi_kotlin
 
     testCompile project(path: ":http4k-core", configuration: 'testArtifacts')
     testCompile Config.TestDependencies
 }
-
-
-