-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the limit on HTTP/2 metadata that can be handled configurable #37372
Conversation
Hi @jaydunk, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
563df63
to
062c1ee
Compare
/retest |
/assign @yanavlasov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wait
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Requested changes from author /wait |
LGTM please check CI and merge main. /wait |
stream configurable. Signed-off-by: Jay Dunkelberger <[email protected]>
Signed-off-by: Jay Dunkelberger <[email protected]>
Signed-off-by: Jay Dunkelberger <[email protected]>
Signed-off-by: Jay Dunkelberger <[email protected]>
Signed-off-by: Jay Dunkelberger <[email protected]>
Signed-off-by: Jay Dunkelberger <[email protected]>
/retest |
@mattklein123 @yanavlasov Does this need one more approval? Looks like the CI is green now. |
Commit Message: Make the limit on HTTP/2 metadata configurable. Defaults to the current hardcoded value of 1 MiB.
Additional Description: The value can be configured through a new field on
Http2ProtocolOptions
Risk Level: Low
Testing: Adds a unit test that covers the new logic in MetadataDecoder
Docs Changes: Added to new proto field but kept hidden to be consistent with other H2 metadata configuration
Release Notes: None
Platform Specific Features: None