Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: deprecate envoy.reloadable_features.xdstp_path_avoid_colon_encoding #38121

Conversation

adisuissa
Copy link
Contributor

Commit Message: xds: deprecate envoy.reloadable_features.xdstp_path_avoid_colon_encoding
Additional Description:
Deprecating envoy.reloadable_features.xdstp_path_avoid_colon_encoding and its legacy code paths.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Fixes: #38057

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38121 was opened by adisuissa.

see: more, trace.

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #38121 was opened by adisuissa.

see: more, trace.

@adisuissa adisuissa marked this pull request as ready for review January 21, 2025 16:01
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @adisuissa!

@botengyao botengyao merged commit fbd8c05 into envoyproxy:main Jan 23, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_xdstp_path_avoid_colon_encoding deprecation
2 participants