Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] deps: Bump rules_java -> 8.7.1 #38162

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Fix #38105

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 23, 2025
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #38162 was opened by dependency-envoy[bot].

see: more, trace.

phlax added 2 commits January 23, 2025 12:59
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member

phlax commented Jan 23, 2025

needs an android fix cc @abeyad

@phlax phlax changed the title deps: Bump rules_java -> 8.7.1 [WIP] deps: Bump rules_java -> 8.7.1 Jan 23, 2025
@phlax phlax marked this pull request as draft January 23, 2025 18:01
@phlax
Copy link
Member

phlax commented Jan 23, 2025

rules_java 8.x is intended for use with Bazel 8 onwards.

bazelbuild/rules_java#233 (comment)

@abeyad
Copy link
Contributor

abeyad commented Jan 23, 2025

@fredyw looked into the rules java updates; I think there were some blockers that needed to be resolved. Fredy could you shed some light?

@fredyw
Copy link
Member

fredyw commented Jan 23, 2025

@fredyw looked into the rules java updates; I think there were some blockers that needed to be resolved. Fredy could you shed some light?

I replied in #37661 (comment) given that I ran into a number of issues with updating Android related rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available rules_java: 8.7.1 (current: 7.12.3)
4 participants