[BREAKING] Add .rendered() and make shallow() and mount() semantics consistent #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Sep 19, 2017
| @@ -3780,7 +3792,7 @@ describe('shallow', () => { | |||
| const wrapper = shallow(<Foo />); | |||
| expect(wrapper).to.have.length(1); | |||
| expect(wrapper.html()).to.equal(null); | |||
| expect(wrapper.type()).to.equal(null); | |||
| expect(wrapper.rendered().length).to.equal(0); | |||
There was a problem hiding this comment.
Why is this not expect(wrapper.rendered()).to.eql([null])?
| @@ -2558,7 +2570,7 @@ describe('shallow', () => { | |||
|
|
|||
| const context = { name: 'foo' }; | |||
| const wrapper = shallow(<Foo />); | |||
| expect(wrapper.find(Bar).shallow({ context }).text()).to.equal('foo'); | |||
| expect(wrapper.find(Bar).shallow({ context }).rendered().text()).to.equal('foo'); | |||
There was a problem hiding this comment.
I think this is the same issue as .first('div') above, let's fix
|
|
||
| wrapper.setProps({ x: 5 }); // Just force a re-render | ||
| expect(wrapper.first('div').text()).to.equal('yolo'); |
There was a problem hiding this comment.
this shouldn't need to be changed
| @@ -4178,7 +4190,7 @@ describe('shallow', () => { | |||
| Foo.displayName = 'CustomWrapper'; | |||
|
|
|||
| const wrapper = shallow(<Wrapper />); | |||
| expect(wrapper.name()).to.equal('CustomWrapper'); | |||
| expect(wrapper.rendered().name()).to.equal('CustomWrapper'); | |||
There was a problem hiding this comment.
add expect(wrapper.name()).to.equal('Wrapper')
| @@ -4319,10 +4331,10 @@ describe('shallow', () => { | |||
|
|
|||
| it('dives + shallow-renders when there is one component child', () => { | |||
| const wrapper = shallow(<DoubleWrapsRendersDOM />); | |||
| expect(wrapper.is(WrapsRendersDOM)).to.equal(true); | |||
| expect(wrapper.rendered().is(WrapsRendersDOM)).to.equal(true); | |||
There was a problem hiding this comment.
add expect(wrapper.is(DoubleWrapsRendersDOM)).to.equal(true)
| @@ -96,7 +96,7 @@ export function generateEmptyRenderData() { | |||
| { message: 'false', value: false, expectResponse: true }, | |||
| { message: 'null', value: null, expectResponse: true }, | |||
|
|
|||
| // Returns false for empty, valid returns | |||
| // // Returns false for empty, valid returns | |||
ljharb
force-pushed
the
master
branch
3 times, most recently
from
40cc703 to
0a17404
Compare
ljharb
force-pushed
the
master
branch
4 times, most recently
from
2227326 to
0d5ead7
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
43eb75e to
39e6b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ljharb
This PR updates shallow() to have similar semantics to mount() with respect to what the wrapper that is returned by them.
The idea is that mount() and shallow() both return a wrapper that's around the Foo itself, and not what it rendered. This means that calling .type() and .instance() on the resulting wrapper will return Foo and an instance of Foo respectively.
This is essentially the alternative to #1107
This is a huge breaking change, and i'm not convinced that this is the right API. But putting up this PR for comments. Theoretically, I find it slightly more appealing than #1107, but there might be some things in this PR that are done slightly wrong. Not sure how I feel TBH.