Add mpDris2-remote.service, --abort-on-disconnect flag #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an implicit pattern rule to convert any `.service.in` file into a `.service` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the second service definition I described in #161 (comment), for systems which use an
mpddaemon that isn't running on the same system as the mpDris2 client.For those systems, a systemd service file
mpDris2-remote.serviceis added to the installation, as an alternative tompDris2.service. (The two services are set to conflict, so that one or the other must be used, but not both.)A new flag,
--abort-on-disconnect, is added to the mpDris2 daemon, and used in thempDris2-remote.serviceto have mpDris2 exit uncleanly when a connection failure occurs. Without it, the exits will be clean exits (intended formpDris2.service).The
--no-reconnectlogic is also extended to the initial connection attempt, so that initial startups will not retry when--no-reconnectis set (with or without--abort-on-disconnect).Other changes
A separate commit updates the Makefile to generate
.servicefiles from.service.infiles via a pattern rule, to avoid duplicating the same command for each.servicefile.