Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2552 - "Calculate Properties" for macromolecules #2743

Merged
merged 8 commits into from
Jan 30, 2025
Merged

#2552 - "Calculate Properties" for macromolecules #2743

merged 8 commits into from
Jan 30, 2025

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Added code to calculate properties. Added UTs

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AliaksandrDziarkach
#2552 - "Calculate Properties" for macromolecules
b51320f 
Added code to calculate properties. Added UTs
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Jan 28, 2025 that may be closed by this pull request
"Calculate Properties" for macromolecules #2552
Closed
AlexanderSavelyev
AlexanderSavelyev requested changes Jan 30, 2025
View reviewed changes
api/c/indigo/indigo.h Outdated Show resolved Hide resolved
api/c/indigo/src/indigo_misc.cpp Outdated Show resolved Hide resolved
api/dotnet/src/IndigoObject.cs Outdated Show resolved Hide resolved
api/java/indigo/src/main/java/com/epam/indigo/IndigoObject.java Outdated Show resolved Hide resolved
api/python/indigo/indigo/indigo_object.py Outdated Show resolved Hide resolved
api/tests/integration/tests/formats/ref/props_double_dna.json Show resolved Hide resolved
api/tests/integration/tests/formats/ref/props_double_dna.json Show resolved Hide resolved
api/tests/integration/tests/formats/ref/props_peptides.json Outdated Show resolved Hide resolved
api/wasm/indigo-ketcher/indigo-ketcher.cpp Outdated Show resolved Hide resolved
@AliaksandrDziarkach
Rename according comments.
f9adfcd 
Remove zeroes.
Fix UTs.
@AlexanderSavelyev AlexanderSavelyev merged commit eb09d37 into master Jan 30, 2025
72 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the feature/2552-macromolecule-properties branch January 30, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Calculate Properties" for macromolecules
2 participants
@AliaksandrDziarkach @AlexanderSavelyev