Get to successful compile #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonyxforce Does "compile" refer to a successful run of |
|
Successful run of |
ephemeralrogue
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Simple changes. This builds on debian, so the _ should be fine. This project will be heading toward a major refactor, so we'll address the file structure at that point. I made a few comments with regard to some things that can be addressed. Overall, great job. Once the requested changes are made and everything looks good, we'll merge it.
ephemeralrogue
requested changes
Oct 31, 2023
… nonsensetwice-main
ephemeralrogue
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Pulled and was able to build. Thank you for this work, @tonyxforce 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried on windows, haven't on any unix-based OS