Update lower title thirds macros to have longer sleep frames #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing flashes of the previous videos when hitting lower title third macros which meant that the macro was keying on too quickly. Fix is to increase the number of frames after loading the video so we can guarantee that the lower-third is loaded in the VTR before keying it on. Increases frames from 1 to 15
tfe
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing flashes of the previous videos when hitting lower title third macros which meant that the macro was keying on too quickly. Fix is to increase the number of frames after loading the video so we can guarantee that the lower-third is loaded in the VTR before keying it on.
Increases frames from 1 to 15