Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: investigate refund option #2644

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

rpc: investigate refund option #2644

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 10, 2025

This tries to investigate NoRefund JSON option for debug_trace* RPC methods. This option seems to disable gas refunds application after any transaction execution. This option is not present in the geth's RPC.

This PR if the option is ever used in Silkworm tests. It seems not.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.62%. Comparing base (b00be69) to head (5bda5aa).

Files with missing lines Patch % Lines
silkworm/core/execution/processor.cpp 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2644      +/-   ##
==========================================
- Coverage   50.64%   50.62%   -0.02%     
==========================================
  Files         784      784              
  Lines       52452    52456       +4     
  Branches     8107     8109       +2     
==========================================
- Hits        26562    26555       -7     
- Misses      23581    23582       +1     
- Partials     2309     2319      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant