Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic #15

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Cyrillic #15

wants to merge 47 commits into from

Conversation

drawcard
Copy link
Contributor

@drawcard drawcard commented Nov 1, 2022

Ok, I think I'm ready to push this to PR now! :)

There may be a second round of minor tweaks & adjustments to come, but it's probably ready for rollout so the wider community can test and give feedback.

I haven't generated the TTFs here, but if this needs to be done I can amend the PR.

Please have a look at the .glyphs file and let me know what you think!

…y, Hardsign-cy, Sha-cy, Shcha-cy, Softsign-cy, Tse-cy, Yu-cy, be-cy, che-cy, de-cy, ef-cy, el-cy, em-cy, en-cy, ereversed-cy, ge-cy, hardsign-cy, ii-cy, iishort-cy, ka-cy, pe-cy, sha-cy, shcha-cy, softsign-cy, te-cy, tse-cy, ve-cy, ya-cy, yeru-cy, yu-cy, ze-cy, zhe-cy
…y, Hardsign-cy, Shcha-cy, Softsign-cy, Tse-cy, be-cy, che-cy, de-cy, ef-cy, el-cy, em-cy, en-cy, ereversed-cy, ge-cy, hardsign-cy, ii-cy, iishort-cy, ka-cy, pe-cy, sha-cy, shcha-cy, softsign-cy, te-cy, tse-cy, ve-cy, ya-cy, yeru-cy, yu-cy, ze-cy, zhe-cy
…y, ereversed-cy, ge-cy, hardsign-cy, ii-cy, iishort-cy, ka-cy, pe-cy, sha-cy, shcha-cy, softsign-cy, te-cy, tse-cy, ve-cy, ya-cy, yeru-cy, yu-cy, ze-cy, zhe-cy
commit 2769da0
Author: Erik Kennedy <[email protected]>
Date:   Thu Oct 20 10:07:57 2022 -0700

    fixing kink in /a

commit cde8e25
Author: Erik Kennedy <[email protected]>
Date:   Wed Oct 19 23:32:59 2022 -0700

    fixing /a overhang

commit c8e292e
Author: Erik Kennedy <[email protected]>
Date:   Wed Oct 19 23:27:47 2022 -0700

    fixing /a upright interpolation

commit a1bff55
Author: Erik Kennedy <[email protected]>
Date:   Wed Oct 19 23:01:29 2022 -0700

    now stylistic set 1 actieve

commit 56eeadb
Author: Erik Kennedy <[email protected]>
Date:   Wed Oct 19 22:41:00 2022 -0700

    updating features in italics

commit 1e85112
Author: Erik Kennedy <[email protected]>
Date:   Mon Oct 17 00:20:34 2022 -0700

    improved spacing for /tf+rounded characters

commit 583e6e0
Author: Erik Kennedy <[email protected]>
Date:   Sat Oct 15 22:25:02 2022 -0700

    modifying bold intermediate masters, fixing bugs, etc

commit baa7cad
Author: Erik Kennedy <[email protected]>
Date:   Fri Oct 14 23:12:42 2022 -0700

    equalizing weight in italic rounds + bug-fixing

commit 62eb29b
Author: Erik Kennedy <[email protected]>
Date:   Tue Oct 4 08:47:54 2022 -0700

    updating banner img w/ italics

commit b50a058
Author: Erik Kennedy <[email protected]>
Date:   Tue Oct 4 08:26:47 2022 -0700

    italics for Latin Core, improved ð, ł, „, etc

commit d067a9c
Author: Erik Kennedy <[email protected]>
Date:   Fri Sep 30 14:20:09 2022 -0700

    more expanded Latin glyphs + italic English improvements

commit 0438aa0
Author: Erik Kennedy <[email protected]>
Date:   Tue Sep 27 23:29:09 2022 -0700

    all multi-use Latin diacritics

commit 95685da
Author: Erik Kennedy <[email protected]>
Date:   Sat Sep 10 23:04:39 2022 -0700

    finishing adding GF Latin Kernel italics

commit 0c28722
Author: Erik Kennedy <[email protected]>
Date:   Sat Sep 10 22:24:09 2022 -0700

    Italics for Latin Kernal charset – except for /$, which requires Glyphs bracket trick
@StefanPeev
Copy link

@drawcard Please send me your Cyrillic version. I would like to have a look at it. My e-mail: [email protected]. Best regards: Stefan Peev

@drawcard
Copy link
Contributor Author

Hi @StefanPeev thanks for your interest - the latest updates for Cyrillic are published to my branch: https://github.com/drawcard/figtree/tree/cyrillic which you can download a ZIP / clone the repo of to check out the source files.

@drawcard
Copy link
Contributor Author

@erikdkennedy could you please refresh my memory, is there anything further I need to do for the commit? eg. generate OTFs etc?

@erikdkennedy
Copy link
Owner

@drawcard You're good! My biggest issue is that if I'm going to incorporate Cyrillic, I would like to get it reviewed by at least one native-reading type designer – which looms like a large enough project in my mind that I've procrastinated on the whole thing. If you know of anyone though, let me know :)

@emmamarichal
Copy link
Contributor

Hello everyone!
I'm Emma and I'm working in the GF team as font onboarder.
I can show the cyrillic to my colleagues, no problem for that.

My only concern is that I don't see any Cyrillic in the Italic version. To onboard this update, we will need the exact same glyphset in Roman and Italic.

Is it something you planned to do @drawcard?
So I think we can close this PR, and if you draw the italic one day, you will open a new one :)

Don't hesitate if you have any questions,
Cheers!
Emma

@drawcard
Copy link
Contributor Author

@erikdkennedy did you want to do the italic conversion, or are you OK with me taking it on? If so please send DM / email me your specs for converting to italic & can give it a shot. I'll wait for @emmamarichal's review before proceeding.

Also @emmamarichal we may produce a Greek character set as requested in #13, do you have anyone on your side who can help with reviewing that, when it's ready?

@emmamarichal
Copy link
Contributor

cc @erikdkennedy
@drawcard I think you can go ahead since you already done the roman version :)

I can eventually ask if somebody can tell me if it's good or not in term of design, to see if we onboard it or not, but we can't really provide a precise review. Our work concerns the technical and QA part. For the design, it would be better if you find someone who is a Greek reader an specialised on this field 👍

@erikdkennedy
Copy link
Owner

@drawcard just emailed you, but posting here for posterity:

  • Slant angle is 9.5°
  • The best way to do it (that I've found) is with the cursify function (as mentioned here), but with caveats:
    • This works way better for straight-edged segments than curved segments. In fact, for the curved forms, I don't even use cursify. Instead, on Jonny Pinhorn's advice, I...
      1. Select a curved glyph (or part of one) like \ocg etc
      2. Rotate right by 4.75°
      3. Slant right by 4.75°
      4. Make further adjustments by hand as needed
    • Cursify is very sensitive to character widths. If your stem widths are close to those listed in the Masters tab of Font Info (e.g. /no), then it will work fantastically. But if not (e.g. /*™️), then you'll get some wonky results, and you'll need to edit by hand
    • A few guidelines:
      • All horizontal parts of letterforms should maintain their thickness
      • Vertical parts should also maintain their thickness, but be slanted 9.5° (easy to see if the stem thickness reporter is enabled)
      • The cardinal sin of automatic slanting is that the NW and SE side of rounds get overly thick, while the NE and SW sides get overly thin. Ideally, all 4 sections are equal. That's where the manual work comes in.
  • Italics is a separate file. As far as I can tell, the best way to add glyphs to italics is by copying them from the upright file and pasting them into the italics file. That will keep the component and spacing and anchor and kerning data. Then you can slant, then hand-adjust as needed.
  • Beware that if a glyph has a component, and you slant the component, then slant the glyph, the component will be slanted at twice the correct angle! So you kind of have to go through them one at a time and make sure each looks good, sometimes cursifying everything, sometimes selecting only the nodes and anchors, but not sub-components, then cursifying just those, etc.

@Aqua-Ye
Copy link

Aqua-Ye commented Sep 11, 2024

@erikdkennedy any plan on trying to fix and merge this in? Looks like @drawcard has been inactive on GitHub (at least publicly) for at least 1 year... so I doubt this will ever be fixed.

@erikdkennedy
Copy link
Owner

erikdkennedy commented Sep 15, 2024 via email

@renatlot
Copy link

renatlot commented Nov 4, 2024

I would still love to have a type-competent native Cyrillic reader give feedback before merging in, but I have zero time to devote to such an effort.

@StefanPeev is profound Cyrillic fonts designer experienced in all Cyrillic (Bulgarian, Ukrainian etc) extended sets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants