Add missing user_ids param from swagger group demote (heroiclabs#450)

Make user_ids param required on group demote api
erlangs · Aug 10, 2020 · cb8fb91 · cb8fb91
1 parent 85a285c
commit cb8fb91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/apigrpc/apigrpc.swagger.json b/apigrpc/apigrpc.swagger.json
@@ -1748,6 +1748,16 @@
             "in": "path",
             "required": true,
             "type": "string"
+          },
+          {
+            "name": "user_ids",
+            "description": "The users to demote.",
+            "in": "query",
+            "required": true,
+            "type": "array",
+            "items": {
+              "type": "string"
+            }
           }
         ],
         "tags": [

diff --git a/server/api_group.go b/server/api_group.go
@@ -712,7 +712,7 @@ func (s *ApiServer) DemoteGroupUsers(ctx context.Context, in *api.DemoteGroupUse
 	}
 
 	if len(in.GetUserIds()) == 0 {
-		return &empty.Empty{}, nil
+		return nil, status.Error(codes.InvalidArgument, "User IDs must be set.")
 	}
 
 	userIDs := make([]uuid.UUID, 0, len(in.GetUserIds()))