Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend structure #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

frontend structure #13

wants to merge 2 commits into from

Conversation

dumb0ctopus
Copy link
Collaborator

No description provided.

@dumb0ctopus dumb0ctopus requested a review from eshiofune March 27, 2024 17:14
Copy link
Owner

@eshiofune eshiofune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot if there's anything visible. If there isn't, feel free to ignore.

@@ -0,0 +1,3 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dumb0ctopus please add to .gitignore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the file. Not needed anyway.

@@ -0,0 +1,23 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a general .gitignore file in the root directory, please copy these to the bottom of that file. You can add a comment like:

'# FRONT END PATTERNS TO IGNORE

...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,25 @@
{
"short_name": "React App",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to do this in a later PR, but let's update these generated names (short_name, name, etc.) anywhere they're auto-generated in the project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dumb0ctopus
Copy link
Collaborator Author

Please add a screenshot if there's anything visible. If there isn't, feel free to ignore.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants