-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restart button to home-assistant-voice.yaml #273
Conversation
@kahrendt , @synesthesiam , @balloob : Feedback welcome on this PR. |
Co-authored-by: Tudor Sandu <[email protected]>
@tetele I've made the change you've requested do I need to make any other changes before we can merge it ? |
I'm not the one to merge this PR, I was merely suggesting an improvement 🙂 |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thx for your contribution. |
Co-authored-by: JLo <[email protected]>
@jlpouffier I've applied the fix per your request. |
@jlpouffier is there anything else that I need to do? Can this PR be merged? |
I've opened a PR to revert this PR. I don't believe that we should add features without a use case attached to it. |
Hi @balloob the use case is to be able to remotely restart your device if you want to |
This Adds a restart button to the device per this issue #270
This would allow people to reboot the PE from the HA UI or via Automation without having to unplug and plug-in the power cable.
Thanks
-DM