Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart button to home-assistant-voice.yaml #273

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

the-mentor
Copy link
Contributor

This Adds a restart button to the device per this issue #270

This would allow people to reboot the PE from the HA UI or via Automation without having to unplug and plug-in the power cable.

Thanks
-DM

@the-mentor
Copy link
Contributor Author

@kahrendt , @synesthesiam , @balloob : Feedback welcome on this PR.

@the-mentor
Copy link
Contributor Author

@tetele I've made the change you've requested do I need to make any other changes before we can merge it ?

@tetele
Copy link
Contributor

tetele commented Jan 7, 2025

I'm not the one to merge this PR, I was merely suggesting an improvement 🙂

@esphome esphome bot marked this pull request as draft January 13, 2025 08:19
@esphome
Copy link

esphome bot commented Jan 13, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jlpouffier
Copy link
Contributor

Thx for your contribution.
Added one comment.
ONce resolved, I'll merge the changes

@the-mentor the-mentor marked this pull request as ready for review January 13, 2025 09:32
@esphome esphome bot requested a review from jlpouffier January 13, 2025 09:32
@the-mentor
Copy link
Contributor Author

@jlpouffier I've applied the fix per your request.

@the-mentor
Copy link
Contributor Author

@jlpouffier is there anything else that I need to do? Can this PR be merged?

@jesserockz jesserockz merged commit f8a0cfc into esphome:dev Jan 15, 2025
10 of 11 checks passed
balloob added a commit that referenced this pull request Jan 19, 2025
@balloob
Copy link
Member

balloob commented Jan 19, 2025

I've opened a PR to revert this PR. I don't believe that we should add features without a use case attached to it.

@the-mentor
Copy link
Contributor Author

Hi @balloob the use case is to be able to remotely restart your device if you want to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants