Skip to content

feat(zigbee): Add method to set/get/report analog output #11431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This pull request introduces updates to the Zigbee library, focusing on enhancing support for analog output functionality.
New methods added:

bool setAnalogOutput(float analog);
float getAnalogOutput();
bool reportAnalogOutput();

Tests scenarios

Tested with ESP32-C6 and the Zigbee_Analog_Input_Output example connecting to the HomeAssistant.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jun 4, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Jun 4, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Zigbee Issues and Feature Request about Zigbee label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9068d88

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Zigbee library to support analog output functionality by adding new APIs and updating related examples.

  • Introduces setAnalogOutput, getAnalogOutput, and reportAnalogOutput methods.
  • Updates the attribute change callback signature and keywords.
  • Adjusts example configurations and usage to target Zigbee coordinator/router devices.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
libraries/Zigbee/src/ep/ZigbeeAnalog.h Added new analog output methods and modified callback signature.
libraries/Zigbee/src/ep/ZigbeeAnalog.cpp Implemented new functions for setting and reporting analog output.
libraries/Zigbee/keywords.txt Updated keywords in line with new API.
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/ci.json Adjusted configuration for router mode.
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/Zigbee_Analog_Input_Output.ino Updated mode check and added a call to setAnalogOutputResolution.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Test Results

 76 files   76 suites   12m 48s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 9068d88.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jun 4, 2025
@me-no-dev me-no-dev merged commit e3018b6 into master Jun 4, 2025
56 checks passed
@me-no-dev me-no-dev deleted the feat/zigbee-analog-output-report branch June 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants