-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello i3water, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL on my comment.
Please also share the boards data sheets or links so I can confirm some settings.
Thank you very much for your patient inspection. I have updated the incorrect settings. |
boards.txt
Outdated
wifiduino32s3.menu.FlashSize.4M=4MB (32Mb) | ||
wifiduino32s3.menu.FlashSize.4M.build.flash_size=4MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the 4MB option as it comes with 16MB or optional 8MB as per docs. Also the 32MB can be removed.
wifiduino32s3.menu.FlashSize.4M=4MB (32Mb) | |
wifiduino32s3.menu.FlashSize.4M.build.flash_size=4MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@i3water This is the last thing waiting on your comment :) Otherwise all looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, it has been modified now.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
update wifiduinov2&wifiduino32s3 boards setting
Tests scenarios
All example codes were verified on the wifiduinov2&wifiduino32s3 board base on Arduino SDK v3.2.0, confirming functionality across different scenarios.
Related links
product link:
https://www.openjumper.com/doc/wifiduino-v2
https://www.openjumper.com/doc/wifiduino32s3