Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redacted spoiler (the rick roll) #1525

Merged
merged 14 commits into from
Feb 26, 2021

Conversation

IHaveNoFunnyName
Copy link
Contributor

Updated the Beanish to point to HTTPS, which let the spoiler work again, but since the kitty gets painted every mNP it refreshes the iframe and it never actually you know, plays.

So now the spoiler is its own element that gets set to the kitty's location whenever it moves.

@IHaveNoFunnyName
Copy link
Contributor Author

IHaveNoFunnyName commented Feb 23, 2021

Ok so now there's two bugs left that I'm 'ok' with, or more likely that i'll fix later.

  1. When the element the spoiler is in is toggled and the kitty jumps, the spoiler is displayed at 0,0 instead of its new location for 1 mNP
  2. When the anchor is in a scrollable element, and is scrolled above or below the element, the spoiler positions itself in open space where the element "should" be. Only really effects the loot plane, if they don't have it paginated, and it appears in badges

E: And done. 2) still happens if it displays below the element, but I'd need the height of the element to fix that, tried getting it a couple of ways but the height it gave back was wrong & didn't update when I changed the elements height. Maybe I could find the id of the element, look it up in the currently active layout and pick the height there, but that seems way too involved.

@IHaveNoFunnyName
Copy link
Contributor Author

Jeez I hope this isn't sending an email for every commit

@eternaldensity eternaldensity merged commit 704637c into eternaldensity:master Feb 26, 2021
@eternaldensity
Copy link
Owner

Fix a weird bug where the kitty wouldn't display a caged puzzle.

Don't think it did afaicr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants