-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redacted spoiler (the rick roll) #1525
Fix redacted spoiler (the rick roll) #1525
Conversation
Ok so now there's two bugs left that I'm 'ok' with, or more likely that i'll fix later.
E: And done. 2) still happens if it displays below the element, but I'd need the height of the element to fix that, tried getting it a couple of ways but the height it gave back was wrong & didn't update when I changed the elements height. Maybe I could find the id of the element, look it up in the currently active layout and pick the height there, but that seems way too involved. |
…ink. I don't get why it's fixed but it's not happening anymore. Anyway, sort of a thematic bug. Like it's actually trapped in the cage.
Jeez I hope this isn't sending an email for every commit |
Don't think it did afaicr |
Updated the Beanish to point to HTTPS, which let the spoiler work again, but since the kitty gets painted every mNP it refreshes the iframe and it never actually you know, plays.
So now the spoiler is its own element that gets set to the kitty's location whenever it moves.