Add EIP: EOA private key deactivation/reactivation #9193
Conversation
github-actions
bot
added
c-new
File
|
eth-bot
added
e-consensus
EIPS/eip-xxxx.md
Outdated
| @@ -0,0 +1,201 @@ | |||
| --- | |||
There was a problem hiding this comment.
| --- | |
| --- | |
| eip: 7851 |
Assigning next sequential EIP/ERC/RIP number.
Numbers are assigned by editors & associates.
Please also update the filename.
There was a problem hiding this comment.
got it. updated in commit 314ed2b.
EIPS/eip-xxxx.md
Outdated
| title: Private key deactivation and reactivation | ||
| description: Introduce a new precompiled contract to enable Externally Owned Accounts (EOAs) to deactivate and reactivate their private keys. | ||
| author: Liyi Guo (@colinlyguo) | ||
| discussions-to: <URL> |
There was a problem hiding this comment.
Please create a discussions topic in Eth Magicians using the template: https://ethereum-magicians.org/c/eips/5
eth-bot
changed the title
eth-bot
changed the title
|
I don't see how this works with 7702 though. If I have the private key of account A, then if I "deactivate" sending txs from A then I can still auth-sign from address B to A, thus removing the "deactivation" from A? Should this add an extra check to 7702 when checking the auth-tuples? If the |
EIPS/eip-7851.md
Outdated
|
|
||
| A new precompiled contract is introduced at address `PRECOMPILE_ADDRESS`. For each call, it consumes `PRECOMPILE_GAS_COST` gas, and the precompiled contract executes the following steps: | ||
|
|
||
| - The precompiled contract checks that the caller is an EOA with delegated code (i.e., its account code begins with the prefix `0xef0100`, as defined in [EIP-7702](./eip-7702)). If the code does not conform to the required prefix, the contract MUST terminate without making any state changes. |
There was a problem hiding this comment.
"Terminate" here means just "stop" the call to this precompile without making any state changes? (One could also "revert", thus the item put on stack when using the CALL* opcodes to this precompile would put 0 on stack if these conditions are not met (so no state changes are done?))
There was a problem hiding this comment.
Thanks for the clarification, the error case of precompile is updated as: "Returns a precompile contract error and consumes all provided gas" (refer to 0f2aaba).
The handling logic is consistent with other precompiles mentioned in https://www.evm.codes/precompiled. Also, consuming all gas for invalid calls (reducing DoS attack vectors) looks reasonable.
For the error return, I searched client implementation in geth and found it handled outside by CALL, STATICCALL, CALLCODE, DELEGATECALL. When precompiles return an error, it will be returned to CALL, and CALL will set return value as 0. But formal documents would help clarify this for sure.
EIPS/eip-7851.md
Outdated
| - The precompile determines the current state of the delegated code based on its byte length: | ||
| - If the delegated code is 24 bytes (`0xef0100 || address || 0x00`), it removes the last byte (`0x00`), transitioning to the active state (`0xef0100 || address`). | ||
| - If the delegated code is 23 bytes (`0xef0100 || address`), it appends `0x00`, transitioning to the deactivated state (`0xef0100 || address || 0x00`). | ||
| - The updated delegated code is saved as the new account code for the EOA. |
There was a problem hiding this comment.
I think a rule should be added here. In case that we are updating the delegated code, but we are running in "static" mode (so a call chain after using STATICCALL) this should abort (revert, no state-changes).
There was a problem hiding this comment.
yes. you're right! I added the STATICCALL error case in this commit: 0f2aaba
eth-bot
changed the title
nice catch. added the extra check you mentioned in the draft. pls refer to this commit: 0f2aaba |
eth-bot
changed the title
|
The commit e8778dc (as a parent of 0008744) contains errors. |
Introduce a new precompiled contract to enable Externally Owned Accounts (EOAs) to deactivate and reactivate their private keys.