-
Notifications
You must be signed in to change notification settings - Fork 124
feat(forks,ci,tox): Create future
feature
#1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some small comments. Feel free to use :)
Co-authored-by: spencer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion and, in general, I'm really happy to improve our fixture release structure and think this goes in the right direction, but:
I wouldn't make this change so shortly before a hard-fork, I think this causes unnecessary changes for downstream teams. I would make this change post Prague.Edit: As-is, this PR doesn't break anything, got corrected by Spencer below 🙂- I find the label
future
misleading; before reading the PR, I assumed that other future EVM features would be included in this release, even for fork N+2. I don't consider this to be coherent naming, e.g., how can we explain to teams that, yes, stateless tests are for a future upgrade, but they're not part of thefuture
release yet. - This configures all Osaka tests to be filled by evmone, not eels, which is not the direction we're aiming for. It might be a technicality, but I think we should only make this change once EELS has full EOF support and we fill EOF tests with EELS. If we assume that's not going to be anytime soon, we might find ourselves having to unwind this change in order to fill EOF with evmone and other Osaka SFI'd EIPs.
About 2., I suggest naming the releases explicitly:
cancun
prague
osaka
I also think it would be cleaner to separate the fork classes change to a separate PR as they're not strictly tied to this packaging change.
One more comment, I think we should also quickly consider how releases look after the ethereum/tests yaml/json files have been moved to eest. We we still be able to deliver a single tarball of all tests for Cancun for example. I think it should be reasonable, but let's check real quick. |
future
featurefuture
feature
Just to push back a little, as I prefer the generality of the naming :)
From my side I don't think this will affect Prague at all, only Osaka
I tend to agree with this! What about
I'm also open to this, verbosity is nice. If we choose this option then we should indeed wait until after the Prague fork. I do prefer |
Thanks @spencer-tb, this is correct, I updated the comment above to reflect this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the get_all_forks return sequence of forks. and some of them are not supposed to be used in test generation. like glaciers.
🗒️ Description
Renames
eip7692
tofuture
, which will now onwards point to the current mainnet deployed hardfork + 2.stable
: Current mainnet deployed hardfork (Currently Cancun)develop
: Current mainnet deployed hardfork + 1 (Currently Prague)future
: Current mainnet deployed hardfork + 2 (Currently Osaka)🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.