feat(beacon): load trusted block root from embedded file #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenev
force-pushed
the
embed-trusted-root
branch
from
4ae8337 to
a38a06a
Compare
KolbyML
requested changes
Feb 18, 2025
ogenev
force-pushed
the
embed-trusted-root
branch
from
a38a06a to
9cf77e9
Compare
I changed it to |
morph-dev
approved these changes
Feb 19, 2025
ogenev
force-pushed
the
embed-trusted-root
branch
from
9cf77e9 to
48f0e98
Compare
ogenev
force-pushed
the
embed-trusted-root
branch
2 times, most recently
from
857388c to
ce12808
Compare
KolbyML
approved these changes
Feb 19, 2025
much cleaner 🚀| @@ -52,7 +53,7 @@ impl BeaconNetwork { | |||
| header_oracle: Arc<RwLock<HeaderOracle>>, | |||
| ) -> anyhow::Result<Self> { | |||
| let config = OverlayConfig { | |||
| bootnode_enrs: portal_config.bootnodes, | |||
| bootnode_enrs: portal_config.bootnodes.clone(), | |||
There was a problem hiding this comment.
Suggested change
| bootnode_enrs: portal_config.bootnodes.clone(), | |
| bootnode_enrs: portal_config.bootnodes, |
Does this need a clone?
There was a problem hiding this comment.
Yeah, because portal_config is used again below.
ogenev
force-pushed
the
embed-trusted-root
branch
from
ce12808 to
9ec14dc
Compare
oac1771
pushed a commit
to oac1771/trin
that referenced
this pull request
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
To facilitate deployments and UX, on the last call we agreed to rely on an embedded trusted block root file as a fallback mechanism (if the user does not provide it via a
--trusted-block-rootflag and if the beacon network is enabled).How was it fixed?
The trusted block root is: 0x107ebc42ce260968c32fba62e2fa6c779f188a0a8c22db0d8afc75801c692fc7.
To-Do