This repository has been archived by the owner on Dec 17, 2023. It is now read-only.
Make the plugin applicable to Settings instances #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gradle wrapper has been updated to 5.3.1 * The com.gradle.build-scan plugin has been updated to a Gradle 5-compatible version * References to the org.gradle.api.internal.tasks.options.Option class that not present in Gradle 5 have been removed and hence the plugin is no longer compatible with pre-4.6 versions of Gradle
|
@etiennestuder could you please review this PR? I'm very interested in this functionality. |
|
@Myllyenko I will. Thanks for the reminder. |
|
@Myllyenko I want to wait with merging this until Gradle 6.0 is out, since I will then deprecate support for Gradle 4.x. This should be in about 6 six weeks from now. |
OK, thanks for the information :) |
|
@Myllyenko I've implemented this functionality in version 2.1. Thanks for the PR. I implemented it a bit differently but drew a lot of inspiration from your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make the plugin applicable to Settings instances. The use case that gave me incentive to make this PR includes usage of credentials for custom repositories inside
pluginManagementblock ofsettings.gradle.As the
Settingsclass becameExtensionAwareonly in Gradle 5.0, I was forced to use Gradle 5 here which broke compatibility of the plugin with Gradle pre-4.6 asorg.gradle.api.internal.tasks.options.Optionwas removed in Gradle 5 whileorg.gradle.api.tasks.options.Optionwas introduced only in Gradle 4.6. I think I can implement a workaround to restore compatibility with older versions if needed.