Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cip UI 1960 blcharts integration #779

Merged
merged 22 commits into from
Nov 28, 2024

Conversation

robgannon-eaton
Copy link
Collaborator

@robgannon-eaton robgannon-eaton commented Nov 22, 2024

It is failing the link checker test. The links do work but they are for things like figma and sharepoint, and seems to be just the checker having access issues?

Any specific feedback you are looking for?

Ive added this to the global index.css to remove the border in the ImageGrid Component but only for these stand alone images

/* Remove border from ImageGrid for BrightlayerCharts integration images*/
img[src*="foundations-chart"],
img[src*="datagranularity"],
img[src*="barcharts-component"],
img[src*="line-chart-component"],
img[src*="piechart-component"] { 
    border: none;
}

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Visit the preview URL for this PR (updated for commit 4507ba7):

https://blui-doc-it--pr779-feature-cipui-1960-b-mg7g3778.web.app

(expires Fri, 29 Nov 2024 12:42:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 590ed6fb71e127776beff0a05819e22fd4307b8f

src/app/components/visualizations/BLCIconButton.tsx Outdated Show resolved Hide resolved
src/app/components/visualizations/BLCIconButton.tsx Outdated Show resolved Hide resolved
src/app/components/visualizations/BLCIconButton.tsx Outdated Show resolved Hide resolved
src/app/components/visualizations/GettingStartedTabs.tsx Outdated Show resolved Hide resolved
src/app/components/visualizations/GettingStartedTabs.tsx Outdated Show resolved Hide resolved
src/app/components/visualizations/GettingStartedTabs.tsx Outdated Show resolved Hide resolved
src/docs/design/intro.mdx Show resolved Hide resolved
@surajeaton surajeaton merged commit 83c870f into dev Nov 28, 2024
9 of 10 checks passed
@surajeaton surajeaton deleted the feature/CIPUI-1960-blcharts-integration branch November 28, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants