Lei/hack202205 #10
Lei/hack202205 #10
Conversation
eddyxu
force-pushed
the
lei/hack202205
branch
2 times, most recently
from
7f017e0
to
aaff37c
Compare
| @@ -0,0 +1,18 @@ | |||
| FROM postgres:14 | |||
There was a problem hiding this comment.
do you want to copy this to Sophon as well so docker-compose spins up a rikai-pg enabled postgres?
There was a problem hiding this comment.
yep, we will build a docker image for services.
| @@ -1,9 +1,9 @@ | |||
| FROM postgres:14 | |||
There was a problem hiding this comment.
should we consolidate this vs the .github/Dockerfile?
There was a problem hiding this comment.
Was a plan to have a playground docker released to docker registry. And another docker for CI.
|
|
||
|
|
||
| class PgModel: | ||
| """PostgreSQL Model""" |
There was a problem hiding this comment.
nit: I think too many things are called "model" now. e.g.:
- we the actual pytorch/tf "model"
- we have the Rikai ModelType which gets assigned to
self.model - And this PgModel is also a "model"
This is probably worth a separate discussion tho.
There was a problem hiding this comment.
Yea, thats true. This is more about a model adaptor
| def schema(self) -> str: | ||
| return self.model.schema() | ||
|
|
||
| def args(self) -> str: |
There was a problem hiding this comment.
don't quite understand what this does, but maybe it'll become clear later
There was a problem hiding this comment.
This was about building the arg list for the PG UDF.
rikai/experimental/pg/model.py
Outdated
|
|
||
| def __repr__(self): | ||
| return f"PgModel({self.model})" | ||
| return f"PGModel(model={self.model})" |
| -- Test data | ||
| -- See images in rikai/tests/conftest.py | ||
| CREATE EXTENSION IF NOT EXISTS pgtap; -- For unit test | ||
| INSERT INTO ml.models (name, flavor, model_type, uri, options) |
There was a problem hiding this comment.
nit: maybe add a description column?
May hackathon for experimental embedding search