chore: remove record schema.org retrieval (#2113)

europeana · Nov 2, 2023 · 7dc760f · 7dc760f
1 parent 2d381ab
commit 7dc760f
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 49 deletions.
diff --git a/packages/portal/.env.example b/packages/portal/.env.example
@@ -170,9 +170,6 @@ OAUTH_CLIENT="YOUR_CLIENT"
 # JIRA_API_SERVICE_DESK_GALLERIES_CUSTOM_FIELD_SET_ID='customfield_10841'
 # JIRA_API_SERVICE_DESK_GALLERIES_CUSTOM_FIELD_SET_CREATOR_NICKNAME='customfield_10842'
 
-# Dataset ID for which to enable schema.org on item pages
-# SCHEMA_ORG_DATASET_ID=2021672
-
 # Comma-separated list of two-letter language codes for which to enable search
 # translation.
 # APP_SEARCH_TRANSLATE_LOCALES=es,de

diff --git a/packages/portal/nuxt.config.js b/packages/portal/nuxt.config.js
@@ -71,7 +71,6 @@ export default {
       featureNotificationExpiration: featureNotificationExpiration(process.env.APP_FEATURE_NOTIFICATION_EXPIRATION),
       internalLinkDomain: process.env.INTERNAL_LINK_DOMAIN,
       notificationBanner: process.env.APP_NOTIFICATION_BANNER,
-      schemaOrgDatasetId: process.env.SCHEMA_ORG_DATASET_ID,
       siteName: APP_SITE_NAME,
       search: {
         collections: {

diff --git a/packages/portal/src/pages/item/_.vue b/packages/portal/src/pages/item/_.vue
@@ -135,15 +135,6 @@
         </client-only>
       </b-container>
     </template>
-    <client-only>
-      <!-- eslint-disable vue/no-v-html -->
-      <script
-        v-if="schemaOrg"
-        type="application/ld+json"
-        v-html="schemaOrg"
-      />
-      <!-- eslint-enable vue/no-v-html -->
-    </client-only>
   </div>
 </template>
 
@@ -208,7 +199,6 @@
         organizations: [],
         places: [],
         relatedCollections: [],
-        schemaOrg: null,
         showItemLanguageSelector: true,
         timespans: [],
         title: null,

diff --git a/packages/portal/src/plugins/europeana/record.js b/packages/portal/src/plugins/europeana/record.js
@@ -201,7 +201,6 @@ export default class EuropeanaRecordApi extends EuropeanaApi {
       organizations,
       places,
       title: proxies.dcTitle,
-      schemaOrg: data.schemaOrg ? Object.freeze(JSON.stringify(data.schemaOrg)) : undefined,
       metadataLanguage: prefLang,
       iiifPresentationManifest: item.iiifPresentationManifest
     };
@@ -224,16 +223,6 @@ export default class EuropeanaRecordApi extends EuropeanaApi {
         params.profile = 'translate';
         params.lang = options.metadataLanguage;
       }
-    } else {
-      // No point in switching on experimental schema.org with item translations.
-      // The profiles would interfere with each other.
-      let schemaOrgDatasetId;
-      if (this.context?.$config?.app?.schemaOrgDatasetId) {
-        schemaOrgDatasetId = this.context?.$config.app.schemaOrgDatasetId;
-      }
-      if (schemaOrgDatasetId && europeanaId.startsWith(`/${schemaOrgDatasetId}/`)) {
-        params.profile = 'schemaOrg';
-      }
     }
 
     return this.axios.get(`${path}${europeanaId}.json`, { params })

diff --git a/packages/portal/tests/unit/plugins/europeana/record.spec.js b/packages/portal/tests/unit/plugins/europeana/record.spec.js
@@ -356,30 +356,6 @@ describe('plugins/europeana/record', () => {
       expect(nock.isDone()).toBe(true);
     });
 
-    describe('profile parameter', () => {
-      it('is "schemaOrg" for configured dataset items', async() => {
-        nock(record.BASE_URL)
-          .get(apiEndpoint)
-          .query(query => query.profile === 'schemaOrg')
-          .reply(200, apiResponse);
-
-        await (new record({ $config: { app: { schemaOrgDatasetId: '123' } } })).getRecord(europeanaId);
-
-        expect(nock.isDone()).toBe(true);
-      });
-
-      it('is omitted for other dataset items', async() => {
-        nock(record.BASE_URL)
-          .get(apiEndpoint)
-          .query(query => !Object.keys(query).includes('profile'))
-          .reply(200, apiResponse);
-
-        await (new record({ $config: { app: { schemaOrgDatasetId: '456' } } })).getRecord(europeanaId);
-
-        expect(nock.isDone()).toBe(true);
-      });
-    });
-
     describe('API response', () => {
       describe('with "Invalid record identifier: ..." error', () => {
         const errorMessage = `Invalid record identifier: ${europeanaId}`;