Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: refactor download attribution and item embed code snippets #2553

Merged
merged 12 commits into from
Feb 5, 2025
Merged

a11y: refactor download attribution and item embed code snippets #2553

merged 12 commits into from
Feb 5, 2025

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Jan 29, 2025 •
edited
Loading

  • Refactors the item attribution (in the DownloadSuccesModal) and ItemEmbedCode into a new component ItemSnippetCopyButton:
    • from forms with textarea's to cite and code elements
    • the text snippet is accompanied by a hidden button for AT (assistive technologies) users to be able to reach, understand and 'click' (copy) the text snippet
    • move the embed code fetch from deprecated ItemEmbedCode to ItemHero (once fetched the embedCode is stored in the component's state preventing re-fetching on modal hide/show)
    • align styles for both snippets to former attribution snippet
  • Sets correct title and header tags for download success and share modals

@github-actions GitHub Actions
Copy link

JIRA ticket: EC-6625

@github-actions GitHub Actions
Copy link

Preview deployment: https://pr-2553.portal-js.dev.eanadev.org/

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lbiedinger lbiedinger merged commit 243148f into master Feb 5, 2025
18 checks passed
@lbiedinger lbiedinger deleted the chore/EC-6625-label-snippets branch February 5, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbiedinger lbiedinger lbiedinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoniePeters @lbiedinger