Fix bug in FileStorage. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileStorage was opening files for writing without turning on truncate, so if the new contents were smaller, we'd leave some of the old file behind, making it invalid JSON.
Gaelan
force-pushed
the
fix_file_storage_bug
branch
from
e0e7c3a to
7ddebf2
Compare
ewilken
approved these changes
Dec 29, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileStorage was opening files for writing without turning on truncate, so if the new contents were smaller, we'd leave some of the old file behind, making it invalid JSON.
This PR fixes that, and adds a test.
Closes #35.