Docker deployment of tidal-dl-ng #341
Conversation
…DME.md to build and run a container that has tidal-dl-ng installed with ffmpeg and path setup in settings.json.
|
Great idea, thank you very much for this PR. To be honest: In my opinion it is not really efficient to keep a separate |
…ned folder creation a bit as well as removed now-useless settings.json from the repo.
|
I modified the |
Dockerfile
Outdated
| RUN apt update | ||
|
|
||
| # Installing nano just in case one need to edit something in the container, installing ffmpeg for tidal-dl-ng | ||
| RUN apt install -y nano ffmpeg |
There was a problem hiding this comment.
Why do you need to install nano? This container is hopefully stable and nobody needs to edit anything in it. I would not recommend to install nano to keep the container as small as possible.
There was a problem hiding this comment.
Indeed it is useless, it is a leftover code, from when I was tinkering, that I forgot to remove. I changed the Dockerfile accordingly, thanks for pointing that out! I also wonder if the modifications I made in the README.md are fitting with the rest of it.
I created a simple Dockerfile starting from a Python Image to build a container with tidal-dl-ng installed and settings.json configured with ffmpeg path. Also modified the README.md in consequence to add instructions on how to build the container and how to run it, trying to make it as simple as possible. I hope this addition can be useful to some people and that this PR is done properly. Feel free to educate me on what to modify to do this better if needed :)