Skip to content

Commit

Permalink
Changed concatination from .merge to +, changed expected tests from 3…
Browse files Browse the repository at this point in the history
…4 to 35
  • Loading branch information
escheiner committed Jul 9, 2021
1 parent 15aa4b7 commit 276b014
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/brakeman/checks/check_sql.rb
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ def check_string_arg exp
]

def ignore_methods_in_sql
@ignore_methods_in_sql ||= IGNORE_METHODS_IN_SQL.merge(tracker.options[:sql_safe_methods] || [])
@ignore_methods_in_sql ||= IGNORE_METHODS_IN_SQL + (tracker.options[:sql_safe_methods] || [])
end

def safe_value? exp
Expand Down
2 changes: 1 addition & 1 deletion test/tests/github_output.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def setup
end

def test_report_format
assert_equal 34, @@report.lines.count
assert_equal 35, @@report.lines.count
@@report.lines.each do |line|
assert line.start_with?('::'), 'Every line must start with `::`'
assert_equal 2, line.scan('::').count, 'Every line must have exactly 2 `::`'
Expand Down

0 comments on commit 276b014

Please sign in to comment.