Get rid of TenantDatabaseDoesNotExist exception

extjac · Jun 29, 2020 · fe52a3c · fe52a3c
1 parent 1e18dc3
commit fe52a3c
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 27 deletions.
diff --git a/src/Bootstrappers/DatabaseTenancyBootstrapper.php b/src/Bootstrappers/DatabaseTenancyBootstrapper.php
@@ -8,7 +8,6 @@
 use Stancl\Tenancy\Contracts\Tenant;
 use Stancl\Tenancy\Contracts\TenantWithDatabase;
 use Stancl\Tenancy\Database\DatabaseManager;
-use Stancl\Tenancy\Exceptions\TenantDatabaseDoesNotExistException;
 
 class DatabaseTenancyBootstrapper implements TenancyBootstrapper
 {
@@ -22,12 +21,6 @@ public function __construct(DatabaseManager $database)
 
     public function bootstrap(Tenant $tenant)
     {
-        /** @var TenantWithDatabase $tenant */
-        $database = $tenant->database()->getName();
-        if (! $tenant->database()->manager()->databaseExists($database)) {
-            throw new TenantDatabaseDoesNotExistException($database);
-        }
-
         $this->database->connectToTenant($tenant);
     }
 

diff --git a/src/Exceptions/TenantCouldNotBeIdentifiedByPathException.php b/src/Exceptions/TenantCouldNotBeIdentifiedByPathException.php
@@ -21,7 +21,7 @@ public function getSolution(): Solution
         return BaseSolution::create('Tenant could not be identified on this path')
             ->setSolutionDescription('Did you forget to create a tenant for this path?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }
diff --git a/src/Exceptions/TenantCouldNotBeIdentifiedByRequestDataException.php b/src/Exceptions/TenantCouldNotBeIdentifiedByRequestDataException.php
@@ -21,7 +21,7 @@ public function getSolution(): Solution
         return BaseSolution::create('Tenant could not be identified with this request data')
             ->setSolutionDescription('Did you forget to create a tenant with this id?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }
diff --git a/src/Exceptions/TenantCouldNotBeIdentifiedOnDomainException.php b/src/Exceptions/TenantCouldNotBeIdentifiedOnDomainException.php
@@ -21,7 +21,7 @@ public function getSolution(): Solution
         return BaseSolution::create('Tenant could not be identified on this domain')
             ->setSolutionDescription('Did you forget to create a tenant for this domain?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }
diff --git a/src/Exceptions/TenantDatabaseDoesNotExistException.php b/src/Exceptions/TenantDatabaseDoesNotExistException.php
diff --git a/tests/CachedTenantResolverTest.php b/tests/CachedTenantResolverTest.php
@@ -109,6 +109,4 @@ public function cache_is_invalidated_when_a_tenants_domain_is_changed()
         $this->assertTrue($tenant->is(app(DomainTenantResolver::class)->resolve('bar')));
         $this->assertNotEmpty(DB::getQueryLog()); // not empty
     }
-
-    // todo2 at some point in the future, we could write invalidation tests for the other resolvers too
 }