Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #14, data binding not working #15

Closed
wants to merge 2 commits into from
Closed

fix #14, data binding not working #15

wants to merge 2 commits into from

Conversation

liujoey
Copy link

@liujoey liujoey commented Jan 21, 2015

by passing a function to the changeWatcher, it make sure when scope.treeData had been changed, the arraySource inside changeWatcher should get a new copy.

@ezraroi
Copy link
Owner

ezraroi commented Jan 21, 2015

I dont understand why you wrap it with jquery element. This is the tree instance of the js tree and it is working fine

@ezraroi ezraroi closed this Jan 22, 2015
@liujoey
Copy link
Author

liujoey commented Jan 22, 2015

in my setup it doesn't work, the scope.tree is just a jqlite DOM element from the document (a div). I'm using angular 1.3.10, jstree 3.0.9, and jQuery 2.1.3. I don't know if something has been changed. Let me try to create the plunker.

-- update --
Yes you are correct, the problem I have is I load the jQuery library in a wrong sequence, it should be load before angular.js. Please feel free the move the 3b35033 commit

@SuricateCan
Copy link
Contributor

The commit 16a5de7 kind of make sense, because if you replace the treeData model, instead of just pushing to it, the reference is lost and no updates are made.

@ezraroi
Copy link
Owner

ezraroi commented Apr 29, 2016

@SuricateCan I am not sure if it a good option to make it work when you replace the reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants